Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966711AbbDXIqS (ORCPT ); Fri, 24 Apr 2015 04:46:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41718 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966383AbbDXIqN (ORCPT ); Fri, 24 Apr 2015 04:46:13 -0400 From: Vitaly Kuznetsov To: Dexuan Cui Cc: KY Srinivasan , Haiyang Zhang , "devel\@linuxdriverproject.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to vmbus_process_offer() References: <1429626460-7947-1-git-send-email-vkuznets@redhat.com> <1429626460-7947-5-git-send-email-vkuznets@redhat.com> Date: Fri, 24 Apr 2015 10:46:06 +0200 In-Reply-To: (Dexuan Cui's message of "Fri, 24 Apr 2015 08:38:25 +0000") Message-ID: <87wq11gbht.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 34 Dexuan Cui writes: >> -----Original Message----- >> From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com] >> Sent: Tuesday, April 21, 2015 22:28 >> To: KY Srinivasan >> Cc: Haiyang Zhang; devel@linuxdriverproject.org; linux- >> kernel@vger.kernel.org; Dexuan Cui >> Subject: [PATCH 4/6] Drivers: hv: vmbus: move init_vp_index() call to >> vmbus_process_offer() >> >> We need to call init_vp_index() after we added the channel to the >> appropriate >> list (global or subchannel) to be able to use this information when assigning >> the channel to the particular vcpu. To do so we need to move a couple of >> functions around. The only real change is the init_vp_index() call. This is a >> small refactoring without a functional change. > > IMO we don't have to move such a big block of code -- we only need to add a > forward function declaration of init_vp_index()? Ok, let's make the change smaller. I'll fix and resend, thanks! > > Thanks, > -- Dexuan -- Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/