Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934663AbbDXJtv (ORCPT ); Fri, 24 Apr 2015 05:49:51 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:35221 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934179AbbDXJtt (ORCPT ); Fri, 24 Apr 2015 05:49:49 -0400 X-AuditID: 85900ec0-a3cccb9000003d4c-a4-553a11b12b43 Subject: [PATCH perf/core v3 0/8] perf-probe: Add filtering features From: Masami Hiramatsu To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Linux Kernel Mailing List , David Ahern , namhyung@kernel.org, Jiri Olsa , Ingo Molnar Date: Fri, 24 Apr 2015 18:47:42 +0900 Message-ID: <20150424094741.23967.758.stgit@localhost.localdomain> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2802 Lines: 84 Hi, Here is a series of patches which improves perf-probe to add filtering features for --list,--del and --funcs. This also includes some bugfixes and cleanups. I've fixed some patches according to Namhyung's review(Thanks!), and splitted the strfilter related patches. Note that first 2 bugfixes are removed from this series, those are already picked by Arnaldo. E.g. --list/--funcs accepts filter rules. ---- # ./perf probe -l vfs\* probe:vfs_read (on vfs_read@ksrc/linux-3/fs/read_write.c) # ./perf probe -l \*libc:\* probe_libc:malloc (on __libc_malloc@malloc/malloc.c in /usr/lib64/libc-2.17.so) ---- ---- # ./perf probe -F *kmalloc __kmalloc devm_kmalloc mempool_kmalloc sg_kmalloc sock_kmalloc ---- Also, --del accepts filter rules too which is more flexible than simple wildcard. ---- # ./perf probe -d 'vfs*|malloc' Removed event: probe:vfs_read Removed event: probe_libc:malloc ---- Changes in v3: - [1/8] Split strfilter__or() and add strfilter__and() from v2 [3/8]. Also rename strfilter__add() to strfilter__append(). - [2/8] Split strfilter__string from v2 [5/8]. Changes in v2: - [2/8] Fix to check errors except -ENOENT on deleting events. - [5/8] Ditto. - [5/8] Fix to check memory allocation error in strfilter__string. - [5/8] Fix to check errors of strfilter__string for verifying given filter. Thank you, --- Masami Hiramatsu (8): perf: Improve strfilter to append additional rules perf: Add strfilter__string to recover rules string perf probe: Accept multiple filter options perf probe: Accept filter argument for --list perf probe: Allow to use filter on --del command perf probe: Accept filter argument for --funcs perf probe: Remove redundant cleanup of params.filter perf probe: Cleanup and consolidate command parsers tools/perf/Documentation/perf-probe.txt | 9 +- tools/perf/builtin-probe.c | 160 +++++++++++++++---------------- tools/perf/util/probe-event.c | 126 +++++++++++------------- tools/perf/util/probe-event.h | 4 - tools/perf/util/strfilter.c | 107 +++++++++++++++++++++ tools/perf/util/strfilter.h | 35 +++++++ 6 files changed, 281 insertions(+), 160 deletions(-) -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/