Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967145AbbDXLW3 (ORCPT ); Fri, 24 Apr 2015 07:22:29 -0400 Received: from mail-db3on0127.outbound.protection.outlook.com ([157.55.234.127]:22912 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966315AbbDXLW1 convert rfc822-to-8bit (ORCPT ); Fri, 24 Apr 2015 07:22:27 -0400 From: "DHANAPAL, GNANACHANDRAN (G.)" To: "gregkh@linuxfoundation.org" CC: "lidza.louina@gmail.com" , "markh@compro.net" , "driverdev-devel@linuxdriverproject.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "Babu, Viswanathan (V.)" , "gnanachandran@gmail.com" Subject: [PATCH] Staging: dgnc: Replace snprintf instead of sprintf Thread-Topic: [PATCH] Staging: dgnc: Replace snprintf instead of sprintf Thread-Index: AQHQfoDwb/U0cJUqTECVB4Kzw63tsw== Date: Fri, 24 Apr 2015 11:22:24 +0000 Message-ID: <20150424112413.GA13642@visteon-gnana> Accept-Language: en-IN, ta-IN, ml-IN, te-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.0.77.198] x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB451; x-microsoft-antispam-prvs: x-forefront-antispam-report: BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(86362001)(2656002)(33656002)(19580395003)(106116001)(46102003)(77156002)(62966003)(19580405001)(92566002)(66066001)(2501003)(40100003)(2900100001)(2860100001)(122556002)(2351001)(229853001)(33716001)(87936001)(50986999)(110136001)(54356999)(102836002);DIR:OUT;SFP:1102;SCL:1;SRVR:AM3PR06MB451;H:AM3PR06MB0856.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010)(3002001);SRVR:AM3PR06MB451;BCL:0;PCL:0;RULEID:;SRVR:AM3PR06MB451; x-forefront-prvs: 05568D1FF7 Content-Type: text/plain; charset="us-ascii" Content-ID: <3D3A98941F577D4990DAC8316E81C256@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2015 11:22:24.9928 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR06MB451 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 27 This patch replaces snprintf instead of sprintf to avoid buffer overflow Signed-off-by: Gnanachandran Dhanapal --- drivers/staging/dgnc/dgnc_mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_mgmt.c b/drivers/staging/dgnc/dgnc_mgmt.c index b13318a..aa20a66 100644 --- a/drivers/staging/dgnc/dgnc_mgmt.c +++ b/drivers/staging/dgnc/dgnc_mgmt.c @@ -116,7 +116,7 @@ long dgnc_mgmt_ioctl(struct file *file, unsigned int cmd, unsigned long arg) spin_lock_irqsave(&dgnc_global_lock, flags); ddi.dinfo_nboards = dgnc_NumBoards; - sprintf(ddi.dinfo_version, "%s", DG_PART); + snprintf(ddi.dinfo_version, strlen(DG_PART)+1, "%s", DG_PART); spin_unlock_irqrestore(&dgnc_global_lock, flags); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/