Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755119AbbDXNAu (ORCPT ); Fri, 24 Apr 2015 09:00:50 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:35734 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbbDXNAs (ORCPT ); Fri, 24 Apr 2015 09:00:48 -0400 Message-ID: <553A3E7D.6040207@acm.org> Date: Fri, 24 Apr 2015 08:00:45 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Hidehiro Kawai CC: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: Fix a problem that messages are not issued in run_to_completion mode References: <5538560C.1040502@hitachi.com> In-Reply-To: <5538560C.1040502@hitachi.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1638 Lines: 43 Ah, yes, you are correct. Queued for 4.1. Thanks. -corey On 04/22/2015 09:16 PM, Hidehiro Kawai wrote: > start_next_msg() issues a message placed in smi_info->waiting_msg > if it is non-NULL. However, sender() sets a message to > smi_info->curr_msg and NULL to smi_info->waiting_msg in the context > of run_to_completion mode. As the result, it leads an infinite > loop by waiting the completion of unissued message when leaving > dying message after kernel panic. > > sender() should set the message to smi_info->waiting_msg not > curr_msg. > > Signed-off-by: Hidehiro Kawai > Cc: Corey Minyard > Cc: openipmi-developer@lists.sourceforge.net > Cc: linux-kernel@vger.kernel.org > --- > drivers/char/ipmi/ipmi_si_intf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 5e90a18..3d49c70 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -942,8 +942,7 @@ static void sender(void *send_info, > * If we are running to completion, start it and run > * transactions until everything is clear. > */ > - smi_info->curr_msg = msg; > - smi_info->waiting_msg = NULL; > + smi_info->waiting_msg = msg; > > /* > * Run to completion means we are single-threaded, no -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/