Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755179AbbDXNDN (ORCPT ); Fri, 24 Apr 2015 09:03:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45333 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752409AbbDXNDJ (ORCPT ); Fri, 24 Apr 2015 09:03:09 -0400 From: Jeff Moyer To: Chao Yu Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] elevator: fix memory leak in ->elevator_init_fn References: <00c701d07e33$acbca360$0635ea20$@samsung.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Fri, 24 Apr 2015 09:03:00 -0400 In-Reply-To: <00c701d07e33$acbca360$0635ea20$@samsung.com> (Chao Yu's message of "Fri, 24 Apr 2015 10:08:43 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 546 Lines: 14 Chao Yu writes: > In ->elevator_init_fn, if we fail to call kzalloc_node, we should release > elevator queue space which is allocated previously, otherwise it will cause > memory leak. > > Signed-off-by: Chao Yu Acked-by: Jeff Moyer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/