Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753075AbbDXNhE (ORCPT ); Fri, 24 Apr 2015 09:37:04 -0400 Received: from mail1.bemta3.messagelabs.com ([195.245.230.174]:60901 "EHLO mail1.bemta3.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbbDXNhB convert rfc822-to-8bit (ORCPT ); Fri, 24 Apr 2015 09:37:01 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-10.tower-39.messagelabs.com!1429882585!23288710!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Dmitry Torokhov , "Opensource [Steve Twiss]" CC: Lee Jones , Samuel Ortiz , DT , David Dajun Chen , INPUT , Ian Campbell , Kumar Gala , LKML , Mark Rutland , "Pawel Moll" , Rob Herring , "Support Opensource" Subject: RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver Thread-Topic: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver Thread-Index: AQHQeQfMnVUuHbQ18kSdUM3dz+iX5J1RULyAgArimUA= Date: Fri, 24 Apr 2015 13:36:22 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B21756B@SW-EX-MBX02.diasemi.com> References: <20150417161555.GB27440@dtor-ws> In-Reply-To: <20150417161555.GB27440@dtor-ws> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1299 Lines: 35 On 17 April 2015 17:16 Dmitry Torokhov wrote > On Fri, Apr 17, 2015 at 01:03:20PM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add OnKey driver support for DA9063 > > > > Isn't this almost to the letter identical to da9062 that I just looked > at? Please find a way to not make a brand new driver for the slightest > variation of the chip... > Hi Dmitry Well, the two chips DA9063 and DA9062 are very different even though their numbers are sequentially 62 and 63. They are different chips and not a simple variation. However the OnKey components to these chips *are* functionally similar which is why I am using the same code. In this case the 62 OnKey driver works the same way as 63 OnKey driver. Has the combined approach been done before? Are there any examples of this that you would like me to follow? I guess I'll drop the OnKey patch for 62 and just concentrate on your comments for 63 instead. After 63 is in a good state then I will work at getting 62 to use a combined driver. Regards, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/