Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753404AbbDXNmz (ORCPT ); Fri, 24 Apr 2015 09:42:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57323 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752493AbbDXNmv (ORCPT ); Fri, 24 Apr 2015 09:42:51 -0400 Date: Fri, 24 Apr 2015 09:42:37 -0400 From: "Frank Ch. Eigler" To: Josh Boyer Cc: "Linux-Kernel@Vger. Kernel. Org" , Josh Stone , Jakub Jelinek , Greg Kroah-Hartman , Linus Torvalds , Andrew Morton , Markus Trippelsdorf , Michel =?iso-8859-1?Q?D=E4nzer?= Subject: Re: [PATCH] Kbuild: Add an option to enable GCC VTA Message-ID: <20150424134237.GA9185@redhat.com> References: <1416595200-22359-1-git-send-email-jistone@redhat.com> <1429824329-40690-1-git-send-email-fche@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 38 Hi, Josh - On Fri, Apr 24, 2015 at 08:40:02AM -0400, Josh Boyer wrote: > [...] > Frank, did you rebase this against some newer tree or something? Yes; the lib/Kconfig.debug part didn't apply to current git. > Curious why you sent it again. At least as a patch-ping; the poor-debuginfo problems are reported to affect non-fedora users too. > > +ifdef CONFIG_DEBUG_INFO_VTA > > +KBUILD_CFLAGS += $(call cc-option, -fvar-tracking-assignments) > > +else > > +KBUILD_CFLAGS += $(call cc-option, -fno-var-tracking-assignments) > > +endif > > + > > Is there a reason you moved this hunk under the DWARF4 options instead > of modifying it in-place like the original patch did? Yes, this version appears a little safer, in the sense that without CONFIG_DEBUG_INFO, neither setting of CONFIG_DEBUG_INFO_VTA would affect the CFLAGS. (In fact, Jakub advises the positive polarity -fvar-tracking-assignments is redundant with -g, and the negative polarity one only provides codegen-bug-protection in the CONFIG_DEBUG_INFO case.) - FChE -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/