Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753599AbbDXNqM (ORCPT ); Fri, 24 Apr 2015 09:46:12 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.111]:27535 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbbDXNqJ (ORCPT ); Fri, 24 Apr 2015 09:46:09 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-9.tower-194.messagelabs.com!1429883163!25747668!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.6; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Paul Bolle , "Opensource [Steve Twiss]" CC: Dmitry Torokhov , Lee Jones , Samuel Ortiz , DT , David Dajun Chen , INPUT , Ian Campbell , Kumar Gala , LKML , Mark Rutland , "Pawel Moll" , Rob Herring , "Support Opensource" Subject: RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver Thread-Topic: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver Thread-Index: AQHQeQfMnVUuHbQ18kSdUM3dz+iX5J1SVzwAgAneKNA= Date: Fri, 24 Apr 2015 13:45:55 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B217581@SW-EX-MBX02.diasemi.com> References: <1429343726.16771.129.camel@x220> In-Reply-To: <1429343726.16771.129.camel@x220> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3ODkHxM001119 Content-Length: 1140 Lines: 31 On 18 April 2015 08:55 Paul Bolle wrote: > There's still a license mismatch left (it probably got lost in the noise > when I finally noticed that the header comment mentioned the LGPL in > V1). > > On Fri, 2015-04-17 at 13:03 +0100, S Twiss wrote: > > + * as published by the Free Software Foundation; either version 2 > > + * of the License, or (at your option) any later version. > > This states the license is GPL v2 or later. > > > +MODULE_LICENSE("GPL v2"); > > And, according to include/linux/module.h, this states the license is > just GPL v2. So I think either the license comment or the license ident > used in the MODULE_LICENSE() macro needs to change. > Got it. Thanks for your comments. I have altered the MODULE_LICENSE() to be "GPL" instead of "GPL v2". That should fix it. That seems to be a fairly common mistake in the kernel. When I did a straw-poll, around 10% of files came up with "GPL v2" and contained "any later version" text. Regards, Steve. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?