Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbbDXOaA (ORCPT ); Fri, 24 Apr 2015 10:30:00 -0400 Received: from p3plsmtpa07-05.prod.phx3.secureserver.net ([173.201.192.234]:48796 "EHLO p3plsmtpa07-05.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754008AbbDXO36 (ORCPT ); Fri, 24 Apr 2015 10:29:58 -0400 Message-ID: <553A5362.3040808@talpey.com> Date: Fri, 24 Apr 2015 10:29:54 -0400 From: Tom Talpey User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org CC: Steve Wise , Jason Gunthorpe , Doug Ledford , Ira Weiny , Tom Tucker , Hoang-Nam Nguyen , Christoph Raisch , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran Subject: Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() References: <1429878230-11749-1-git-send-email-yun.wang@profitbricks.com> <1429878230-11749-2-git-send-email-yun.wang@profitbricks.com> In-Reply-To: <1429878230-11749-2-git-send-email-yun.wang@profitbricks.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1108 Lines: 35 On 4/24/2015 8:23 AM, Michael Wang wrote: > Add new callback query_transport() and implement for each HW. > > Mapping List: > node-type link-layer old-transport new-transport > ... > mlx4 IB_CA IB/ETH IB IB/IBOE > mlx5 IB_CA IB IB IB > ... > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c > index 57c9809..b6f2f58 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -262,6 +262,12 @@ out: > return err; > } > > +static enum rdma_transport_type > +mlx5_ib_query_transport(struct ib_device *device, u8 port_num) > +{ > + return RDMA_TRANSPORT_IB; > +} > + Just noticed that mlx5 is not being coded as RoCE-capable like mlx4. The mlx5 driver is for the new ConnectX-4, which implements all three of IB, RoCE and RoCEv2, right? Are those last two not supported? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/