Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756531AbbDXPMU (ORCPT ); Fri, 24 Apr 2015 11:12:20 -0400 Received: from mail-db3on0058.outbound.protection.outlook.com ([157.55.234.58]:9120 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751922AbbDXPMQ convert rfc822-to-8bit (ORCPT ); Fri, 24 Apr 2015 11:12:16 -0400 From: Liran Liss To: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Steve Wise , Tom Talpey , Jason Gunthorpe , Doug Ledford , Ira Weiny , Tom Tucker , Hoang-Nam Nguyen , "raisch@de.ibm.com" , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , "Or Gerlitz" , Haggai Eran Subject: RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() Thread-Topic: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() Thread-Index: AQHQfomPoPX0+sSpXE6kfObNsvjNTp1cQoNA Date: Fri, 24 Apr 2015 15:12:13 +0000 Message-ID: References: <1429878230-11749-1-git-send-email-yun.wang@profitbricks.com> <1429878230-11749-2-git-send-email-yun.wang@profitbricks.com> In-Reply-To: <1429878230-11749-2-git-send-email-yun.wang@profitbricks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [85.250.13.154] authentication-results: profitbricks.com; dkim=none (message not signed) header.d=none; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB445; x-forefront-antispam-report: BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(51704005)(51444003)(2201001)(76176999)(40100003)(54356999)(50986999)(66066001)(19580395003)(102836002)(5001770100001)(2501003)(106116001)(77156002)(2656002)(87936001)(86362001)(2900100001)(74316001)(46102003)(92566002)(62966003)(33656002)(19580405001)(2950100001)(76576001)(122556002)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR05MB445;H:DB4PR05MB0863.eurprd05.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006)(3002001);SRVR:DB4PR05MB445;BCL:0;PCL:0;RULEID:;SRVR:DB4PR05MB445; x-forefront-prvs: 05568D1FF7 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2015 15:12:13.8758 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR05MB445 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 37 > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > [snip] > a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > 65994a1..d54f91e 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -75,10 +75,13 @@ enum rdma_node_type { }; > > enum rdma_transport_type { > + /* legacy for users */ > RDMA_TRANSPORT_IB, > RDMA_TRANSPORT_IWARP, > RDMA_TRANSPORT_USNIC, > - RDMA_TRANSPORT_USNIC_UDP > + RDMA_TRANSPORT_USNIC_UDP, > + /* new transport */ > + RDMA_TRANSPORT_IBOE, Remove RDMA_TRANSPORT_IBOE - it is not a transport. ROCE uses IBTA transport. If any code should test for ROCE should invoke a specific helper, e.g., rdma_protocol_iboe(). This is what you currently call "rdma_tech_iboe" is patch 02/26. I think that pretty much everybody agrees that rdma_protocol_*() is a better name than rdma_tech_*(), right? So, let's change this. The semantics are: "check that a link supports a certain wire protocol, or a set of wire protocols", where 'certain' refers to the specific helper... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/