Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965586AbbDXQWn (ORCPT ); Fri, 24 Apr 2015 12:22:43 -0400 Received: from foss.arm.com ([217.140.101.70]:53530 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965151AbbDXQWl (ORCPT ); Fri, 24 Apr 2015 12:22:41 -0400 Date: Fri, 24 Apr 2015 17:22:38 +0100 From: Will Deacon To: Arnaldo Carvalho de Melo Cc: David Ahern , "linux-kernel@vger.kernel.org" , Mark Rutland , Jiri Olsa , Namhyung Kim , Arnaldo Carvalho de Melo Subject: Re: arm/arm64 perf build issue with mainline Message-ID: <20150424162238.GD7313@arm.com> References: <20150423112916.GF1652@arm.com> <20150423140454.GJ1652@arm.com> <5538FEAF.5040804@oracle.com> <20150424161058.GA19673@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150424161058.GA19673@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1321 Lines: 32 On Fri, Apr 24, 2015 at 05:10:58PM +0100, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 23, 2015 at 08:16:15AM -0600, David Ahern escreveu: > > On 4/23/15 8:04 AM, Will Deacon wrote: > > >+++ b/tools/perf/Makefile > > >@@ -24,7 +24,7 @@ unexport MAKEFLAGS > > > # (To override it, run 'make JOBS=1' and similar.) > > > # > > > ifeq ($(JOBS),) > > >- JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null) > > >+ JOBS := $(shell getconf _NPROCESSORS_ONLN 2>/dev/null) > > > ifeq ($(JOBS),0) > > > JOBS := 1 > > > endif > > > Certainly a more robust way of doing it but I am concerned this > > might end up breaking others. For Fedora at least getconf is in the > > glibc-common package and there are users that do not build with > > glibc. It is not clear if the build system for those environments > > will have getconf. > > Hum, perhaps check if getconf is present, if not fallback to the egrep > -c? I'll try. I don't have a SPARC machine to hand, but we could check that the character immediately following "CPU" is a number [0-9]. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/