Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967136AbbDXQ3b (ORCPT ); Fri, 24 Apr 2015 12:29:31 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:38478 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933009AbbDXQ32 (ORCPT ); Fri, 24 Apr 2015 12:29:28 -0400 Date: Fri, 24 Apr 2015 10:29:14 -0600 From: Jason Gunthorpe To: Liran Liss Cc: Michael Wang , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Steve Wise , Tom Talpey , Doug Ledford , Ira Weiny , Tom Tucker , Hoang-Nam Nguyen , "raisch@de.ibm.com" , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran Subject: Re: [PATCH v6 02/26] IB/Verbs: Implement raw management helpers Message-ID: <20150424162914.GA9305@obsidianresearch.com> References: <1429878230-11749-1-git-send-email-yun.wang@profitbricks.com> <1429878230-11749-3-git-send-email-yun.wang@profitbricks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.183 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 886 Lines: 23 On Fri, Apr 24, 2015 at 03:15:54PM +0000, Liran Liss wrote: > > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > > +static inline int rdma_tech_iboe(struct ib_device *device, u8 port_num) > > +{ > > + return device->query_transport(device, port_num) > > + == RDMA_TRANSPORT_IBOE; > > Remove RDMA_TRANSPORT_IBOE. > In the current code, the test should be: (IB transport && Ethernet link layer). No, if this rmda_tech stuff is to reflect the specification the port implements, then RoCEE is a valid specification (IBA Annex A16), as it RoCEEv2 (A17). This patch set is trying to drop then link layer concept entirely. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/