MIME-Version: 1.0
In-Reply-To: <1429889495-27850-3-git-send-email-dvlasenk@redhat.com>
References: <1429889495-27850-1-git-send-email-dvlasenk@redhat.com> <1429889495-27850-3-git-send-email-dvlasenk@redhat.com>
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Fri, 24 Apr 2015 21:35:08 +0200
Message-ID: <CAK1hOcPcarW2z3mNAmLt9m-dYbkqeA0tiw9k=D+OYqkvmqCdNw@mail.gmail.com>
Subject: Re: [PATCH 3/3] x86: Define cpu_current_top_of_stack for 64-bit code
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1038
Lines: 26

On Fri, Apr 24, 2015 at 5:31 PM, Denys Vlasenko <dvlasenk@redhat.com>
> diff --git a/arch/x86/include/asm/processor.h
b/arch/x86/include/asm/processor.h
> index 23ba676..3754dac 100644
> --- a/arch/x86/include/asm/processor.h
> +++ b/arch/x86/include/asm/processor.h
> @@ -304,6 +304,8 @@ DECLARE_PER_CPU_SHARED_ALIGNED(struct tss_struct, cpu_tss);
>
>  #ifdef CONFIG_X86_32
>  DECLARE_PER_CPU(unsigned long, cpu_current_top_of_stack);
> +#else
> +#define cpu_current_top_of_stack (cpu_tss + TSS_sp0)
>  #endif
>
>  /*
> diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h


Oops... this hunk (one touching processor.h) shouldn't be there.
It is bogus. It works simply because this define isn't used
by 64-bit builds. Just drop this hunk. The rest is correct.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/