Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031655AbbDXTt4 (ORCPT ); Fri, 24 Apr 2015 15:49:56 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:45822 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031510AbbDXTty (ORCPT ); Fri, 24 Apr 2015 15:49:54 -0400 Date: Fri, 24 Apr 2015 14:48:27 -0500 From: Felipe Balbi To: David Cohen CC: Felipe Balbi , , , , Subject: Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume Message-ID: <20150424194827.GB22447@saruman.tx.rr.com> Reply-To: References: <1429296116-3062-1-git-send-email-david.a.cohen@linux.intel.com> <20150417194327.GM2823@saruman.tx.rr.com> <20150423223748.GA19774@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz" Content-Disposition: inline In-Reply-To: <20150423223748.GA19774@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3463 Lines: 95 --eJnRUKwClWJh1Khz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Thu, Apr 23, 2015 at 03:37:48PM -0700, David Cohen wrote: > On Fri, Apr 17, 2015 at 02:43:27PM -0500, Felipe Balbi wrote: > > On Fri, Apr 17, 2015 at 11:41:56AM -0700, David Cohen wrote: > > > From: Felipe Balbi > >=20 > > missing the required: > >=20 > > [ Upstream commit bc5ba2e0b829c9397f96df1191c7d2319ebc36d9 ] > >=20 > > >=20 > > > When going into bus suspend/resume we _must_ > > > call gadget driver's ->suspend/->resume callbacks > > > accordingly. This patch implements that very feature > > > which has been missing forever. > > >=20 > > > Cc: # 3.14 > > > Signed-off-by: Felipe Balbi > > > Signed-off-by: David Cohen > > > --- > > >=20 > > > Hi, > > >=20 > > > This patch was introduced on v3.15. > > > But the issue it fixes already existed on v3.14 and v3.14 is a long t= erm > > > support version. > >=20 > > Can you show me a log of this breaking anywhere ? Why do you consider > > this a bug fix ? What sort of drawbacks did you notice ? >=20 > We're seeing BC1.2 compliance test failure. I borrowed this info from > the bug report :) >=20 > 1. BC1.2 compliance testing - SDP2.0 > ----------------------------------------------- > 1. On Connect to active Host (Expected result: 100mA to 500mA): > Actual result 100mA to 500mA >=20 > 2. On Host Suspend (ER: Fall back to 0mA): > not falling back to 0mA, remains at 500mA >=20 > 3. On Connect to Suspended Host (ER: 100mA to 0mA): > cable-props shown as 100mA, which means drawing a current of 100mA from > Suspended Host >=20 > 4. On making Host active (ER: 500mA): > 500mA But we don't support Battery Charging with dwc3 as of now :-) In fact, just note that none of the BC registers are even defined in the current driver anywhere. Seems like you should cherry-pick these to your vendor tree, but v3.14 vanilla, because it doesn't support BC1.2, can't be claimed to be at fault, right ? I'll leave the final decision to Greg and I don't really oppose having both patches on v3.14-stable, but this is not a bug fix in my view. --=20 balbi --eJnRUKwClWJh1Khz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVOp4LAAoJEIaOsuA1yqRE8ZUQAIY4yaF/7JphfyKXJi8XKGiT QFQWNsDUQguNiKMf61qH6TSlV/RfNcxd7lpHR++WATcwRWZ/aCE13bDHeqaYUZ7z 0UOi8/vFPh7DaGpSmjoE1vo0EHNfg9VlnRwvP3l1ssSxENu+UNDv8tAPEdX7NuqY DCTliaWaQOevyJB31EeRABBrUTP8TB2tvDRAZONufbCrUOphmWxj65PjOn2Hqgcf X/5MBjtYgFXNtut2pd0kybIm5U6YnSPaIdhXcQnTOOCr3YqGc3PwuU4Z0Z6nzoJ8 RNZ3g02A1q6BLBusKojmr1YKDQJA3CtO774Z3lwr1+X92oy5RiUH1TFoHAiN2ANz 1Nd9CHNGUQbQkXhAU/gtCPriUgJ00wncGubEQPZihoiC1wrczOJs5hOKQXKMko0U PFHXbopowsYcp8FhtM19izu0/oLNFhKJxldoXzW0HltJZOmWbmXETce5yzL6JUAj 90w7vEPVdFQK5JtAEKXdH6fi2eXxxE8Ri4AXC/pSKUDjgJjdR/wIqGLmexh058t+ F31ZUM9oAUUN4Wu0PIvZRIL+pJG1icOl5cyviD5Lx7/8BWfRji3o+ZRwkIjPmlrz jP5Ds6izcIsbRge4S6BcQdFRVnKpLbB52K7LmpCbjigSVTNunPswgjNU2Kk4w9ig CMS8ltCI4+DWxxsa0k4n =L7zt -----END PGP SIGNATURE----- --eJnRUKwClWJh1Khz-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/