Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbbDYCpN (ORCPT ); Fri, 24 Apr 2015 22:45:13 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:32813 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbbDYCpK (ORCPT ); Fri, 24 Apr 2015 22:45:10 -0400 MIME-Version: 1.0 In-Reply-To: <1429915008-22015-2-git-send-email-cernekee@chromium.org> References: <1429915008-22015-1-git-send-email-cernekee@chromium.org> <1429915008-22015-2-git-send-email-cernekee@chromium.org> From: Kevin Cernekee Date: Fri, 24 Apr 2015 19:44:45 -0700 Message-ID: Subject: Re: [PATCH V2 1/4] regmap: cache: Add "was_reset" argument to regcache_sync_region() To: Liam Girdwood , Mark Brown Cc: Lars-Peter Clausen , dgreid@chromium.org, Andrew Bresticker , Olof Johansson , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1379 Lines: 27 On Fri, Apr 24, 2015 at 3:36 PM, Kevin Cernekee wrote: > regcache_sync() and regcache_sync_region() currently assume that the > hardware has just emerged from a clean reset, and that all registers are > in their default states. But that isn't the only possibility; the device > may have been in a different state in which the registers were > inaccessible but have retained their contents, e.g. clock gating. > > So we will extend the more versatile of the two functions, > regcache_sync_region(), to let the caller decide what assumptions should > be made. > > One driver that can benefit from this is adau1977, which has hacks to > overwrite the registers that regcache_sync() might have missed. Also, > the powerdown pin on tas571x does not reset the register contents either, > so a similar feature will be required by that driver. > > This commit just adds the new argument by changing the function > declarations and call sites, but doesn't wire it up yet. The last two lines of the changelog were inadvertently carried over from an older version of the patch, and should be deleted. Will fix in V3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/