Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbbDYD7l (ORCPT ); Fri, 24 Apr 2015 23:59:41 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56505 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbbDYD7i (ORCPT ); Fri, 24 Apr 2015 23:59:38 -0400 Date: Fri, 24 Apr 2015 23:59:36 -0400 (EDT) Message-Id: <20150424.235936.1118209212526994419.davem@davemloft.net> To: joe@perches.com Cc: m.grzeschik@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros From: David Miller In-Reply-To: <1429916685.23327.32.camel@perches.com> References: <1429896055-31680-1-git-send-email-m.grzeschik@pengutronix.de> <1429896055-31680-7-git-send-email-m.grzeschik@pengutronix.de> <1429916685.23327.32.camel@perches.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 24 Apr 2015 20:59:38 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 742 Lines: 18 From: Joe Perches Date: Fri, 24 Apr 2015 16:04:45 -0700 > On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: >> The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK >> and ADIAGSTATUS are unnecessary indirections to the use of registers. >> This patch removes them and improves the readability of the code. > > This breaks compilation. > > Please compile test your patches before sending them. This makes this patch series even more unacceptable. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/