Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757758AbbDYJAW (ORCPT ); Sat, 25 Apr 2015 05:00:22 -0400 Received: from lb2-smtp-cloud6.xs4all.net ([194.109.24.28]:53363 "EHLO lb2-smtp-cloud6.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755164AbbDYJAM (ORCPT ); Sat, 25 Apr 2015 05:00:12 -0400 Message-ID: <1429952401.2927.91.camel@x220> Subject: Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger From: Paul Bolle To: Anda-Maria Nicolae Cc: sre@kernel.org, dbaryshkov@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Sat, 25 Apr 2015 11:00:01 +0200 In-Reply-To: <1429862240-21619-1-git-send-email-anda-maria.nicolae@intel.com> References: <1429862240-21619-1-git-send-email-anda-maria.nicolae@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 32 Just a single nit: a license mismatch. On Fri, 2015-04-24 at 10:57 +0300, Anda-Maria Nicolae wrote: > --- /dev/null > +++ b/drivers/power/rt9455_charger.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. This states the license is GPL v2 or later. > +MODULE_LICENSE("GPL v2"); And, according to include/linux/module.h, this states the license is (only) GPL v2. So I think either the license comment or the ident used in the MODULE_LICENSE() macro should be changed. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/