Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933674AbbDYLfX (ORCPT ); Sat, 25 Apr 2015 07:35:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:36946 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754163AbbDYLfT (ORCPT ); Sat, 25 Apr 2015 07:35:19 -0400 Date: Sat, 25 Apr 2015 12:35:09 +0100 From: Mark Brown To: Kevin Cernekee Cc: lgirdwood@gmail.com, lars@metafoo.de, dgreid@chromium.org, abrestic@chromium.org, olofj@chromium.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150425113509.GB31708@sirena.org.uk> References: <1429915008-22015-1-git-send-email-cernekee@chromium.org> <1429915008-22015-4-git-send-email-cernekee@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline In-Reply-To: <1429915008-22015-4-git-send-email-cernekee@chromium.org> X-Cookie: Swap read error. You lose your mind. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH V2 3/4] ASoC: tas571x: New driver for TI TAS571x power amplifiers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1477 Lines: 42 --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Apr 24, 2015 at 03:36:47PM -0700, Kevin Cernekee wrote: > + gpiod_set_value(priv->pdn_gpio, 0); > + usleep_range(5000, 6000); > + > + regcache_cache_only(priv->regmap, false); > + ret = regcache_sync_region(priv->regmap, 0, > + priv->chip->regmap_config->max_register, false); > + if (ret) > + return ret; This is also a problem with your first patch BTW - even if we are going to add an argument we shouldn't be having drivers do _sync_region() to sync the entire register map, that's just ugly. --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVO3vtAAoJECTWi3JdVIfQgwIH/2pCj1ZWoqOCcskJNM94B18g SD0o+3YY3Nzwb+dvcAP9Z1wpLKBx9CtVfKzEeVZ6qICLZmeBzzerKC3N8R+1qNF3 n89vboB19vfwLSd2jQvVmgWsvEgWraZ4XubrY+QoGmOsFtkFBWuoHiSryj10QtUm q0w9eyp3fhkQ8lXP0P2eg997kjm1ktCsj9ffPDczpuNkfTm8pSdu2TyhCjDDUNpb hSOSWfb1rn4NOAtd0fcaAyDOGWWe9beuR20mJXA9aWPgI8HjPxpnxqG7+NLjhzJh XlJHK7IdZOtlsynu25p3V/CF7kGZEOUi+hpDSvUrEie1d65XQK+fyDw+Sd6uisU= =9hPX -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/