Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965415AbbDYPtR (ORCPT ); Sat, 25 Apr 2015 11:49:17 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44026 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965139AbbDYPtK (ORCPT ); Sat, 25 Apr 2015 11:49:10 -0400 Date: Sat, 25 Apr 2015 10:47:42 -0500 From: Felipe Balbi To: David Cohen CC: Felipe Balbi , , , , Subject: Re: [PATCH] usb: dwc3: gadget: call gadget driver's ->suspend/->resume Message-ID: <20150425154742.GA28985@saruman.tx.rr.com> Reply-To: References: <1429296116-3062-1-git-send-email-david.a.cohen@linux.intel.com> <20150417194327.GM2823@saruman.tx.rr.com> <20150423223748.GA19774@psi-dev26.jf.intel.com> <20150424194827.GB22447@saruman.tx.rr.com> <20150424205625.GA10838@psi-dev26.jf.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <20150424205625.GA10838@psi-dev26.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4322 Lines: 116 --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, Apr 24, 2015 at 01:56:25PM -0700, David Cohen wrote: > > > > > When going into bus suspend/resume we _must_ > > > > > call gadget driver's ->suspend/->resume callbacks > > > > > accordingly. This patch implements that very feature > > > > > which has been missing forever. > > > > >=20 > > > > > Cc: # 3.14 > > > > > Signed-off-by: Felipe Balbi > > > > > Signed-off-by: David Cohen > > > > > --- > > > > >=20 > > > > > Hi, > > > > >=20 > > > > > This patch was introduced on v3.15. > > > > > But the issue it fixes already existed on v3.14 and v3.14 is a lo= ng term > > > > > support version. > > > >=20 > > > > Can you show me a log of this breaking anywhere ? Why do you consid= er > > > > this a bug fix ? What sort of drawbacks did you notice ? > > >=20 > > > We're seeing BC1.2 compliance test failure. I borrowed this info from > > > the bug report :) > > >=20 > > > 1. BC1.2 compliance testing - SDP2.0 > > > ----------------------------------------------- > > > 1. On Connect to active Host (Expected result: 100mA to 500mA): > > > Actual result 100mA to 500mA > > >=20 > > > 2. On Host Suspend (ER: Fall back to 0mA): > > > not falling back to 0mA, remains at 500mA > > >=20 > > > 3. On Connect to Suspended Host (ER: 100mA to 0mA): > > > cable-props shown as 100mA, which means drawing a current of 100mA= from > > > Suspended Host > > >=20 > > > 4. On making Host active (ER: 500mA): > > > 500mA > >=20 > > But we don't support Battery Charging with dwc3 as of now :-) In fact, > > just note that none of the BC registers are even defined in the current > > driver anywhere. Seems like you should cherry-pick these to your vendor > > tree, but v3.14 vanilla, because it doesn't support BC1.2, can't be > > claimed to be at fault, right ? >=20 > We could call it a missing feature that could lead to a potential bug :) > By your own comment, he "must" was stressed out: sure it was because they really must be called :-) However, the only actual problem that arises from not calling them is with something that's not supported :-) > When going into bus suspend/resume we _must_ > call gadget driver's ->suspend/->resume callbacks > accordingly. This patch implements that very feature > which has been missing forever. > ''' >=20 > Since v3.14 is a LTS kernel and the changes are safe, it's worth to > consider. definitely worth to consider, but not as something that fixes BC1.2 because that's, as said, not supported in any public tree :-) > > I'll leave the final decision to Greg and I don't really oppose having > > both patches on v3.14-stable, but this is not a bug fix in my view. >=20 > Thanks. I appreciate your feedback. >=20 > BR, David >=20 > PS: FWIW implementing features or fixing bugs aren't much different tasks: > https://geekwhisperin.files.wordpress.com/2009/09/bug-vs-feature.jpg Yes, I used to have that on my office door ;-) --=20 balbi --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVO7ceAAoJEIaOsuA1yqREzbcP/0J3ASI+yrawzLOj0JEL7hCq fjPNIO3YDUlBMhbmfA/oOijYY+vL1dLrWDH6FNDdTJAmlUUo2tTAQgOQaZOJOuqx dh7xFwlEpdXKNhtojrrW+w4OQO3SOyTK2vAGTbi5lqO2ZcIWgXClHXrlUIVea2e6 7vA5KptI9PxlHssHtEd6daF0wyLZOdHeWv+sxelyL/Nx6UDZ2Z1MtnEmNl9bSkcO SyotbUt8mHiuLqlMHGuJG/R5Jp45hTfjJaV0shb+aD2Lhfxa5nHFpHIsVDtPgR7v 4mATB5Sq7DjSYYx7qJKQ5Flo+G9qDfcVxKntcleX1+5wog2EUlhO8UGUAnzKhRis APJhM991ifhU7lNiSybaiO3r0wIhnoh/Z1U48+Gp4HfxH6Zplnu9sApK0zZr4zYq NNh79QwBN+oTKG1qw6n5nCbWEbLrLFLZe9Q480T3f5wTpCSVxd8Vi7A/EigpWt3m +56whRu8HSul+XQzkPY9lGsuqbTtKfwgEWPSJvo6g/2FscJfVYD6VsX40AwU+tCJ WkimcuT5bMZqwPxX8HTThbfNJvke6vq2cVaVFewZePf470CTg2fs4dJf61Q1ZJIo eskiN+G4MBvAh6tgZSC42RQa4kbQYWrRVWxEN7o+okcu0EmVAFl/tGSvgyCQLwfw 2tq2FmWfyQMRx+urrx89 =1Y2f -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/