Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751930AbbDYSoE (ORCPT ); Sat, 25 Apr 2015 14:44:04 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35287 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbbDYSoC (ORCPT ); Sat, 25 Apr 2015 14:44:02 -0400 Date: Sat, 25 Apr 2015 14:44:00 -0400 (EDT) Message-Id: <20150425.144400.1784698109604961465.davem@davemloft.net> To: vbridger@opensource.altera.com Cc: netdev@vger.kernel.org, nios2-dev@lists.rocketboards.org, linux-kernel@vger.kernel.org, vbridger@altera.com, cnphoon@altera.com, ennoerlangen@gmail.com Subject: Re: [PATCH] net: eth: altera: Resolve false errors from MSGDMA to TSE From: David Miller In-Reply-To: <1429860727-1359-1-git-send-email-vbridger@opensource.altera.com> References: <1429860727-1359-1-git-send-email-vbridger@opensource.altera.com> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 25 Apr 2015 11:44:02 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1156 Lines: 27 From: Vince Bridgers Date: Fri, 24 Apr 2015 02:32:07 -0500 > From: Chee Nouk Phoon > > This patch resolves false errors from MSGDMA in TX mSGDMA MM to ST > mode, and is a continuation of the patch recently submitted by Andrea > Oetken. The MSGDMA had a logic bug that masked detection of this issue > prior to Quartus 14.1/Build 164. When the MSGDMA logic bug was addressed > in Quartus 14.1/Build 164, the driver problem was exposed. > > The problem is corrected by making sure MSGDMA_DESC_CTL_TR_ERR_IRQ is not > set for any of the transmit DMA descriptors, and only used for receive > descriptors. > > Fixes: 71cd26e altera tse: Error-Bit on tx-avalon-stream always set. > > Signed-off-by: Chee Nouk Phoon > Signed-off-by: Vince Bridgers a > Cc: Andreas Oetken Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/