Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223AbbDYUm4 (ORCPT ); Sat, 25 Apr 2015 16:42:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36337 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbbDYUmy (ORCPT ); Sat, 25 Apr 2015 16:42:54 -0400 Date: Sat, 25 Apr 2015 22:42:52 +0200 (CEST) From: Jiri Kosina To: Josh Poimboeuf cc: Seth Jennings , Vojtech Pavlik , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] livepatch: x86: make kASLR logic more accurate In-Reply-To: <20150424215526.GB27123@treble.redhat.com> Message-ID: References: <20150424215526.GB27123@treble.redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1096 Lines: 29 On Fri, 24 Apr 2015, Josh Poimboeuf wrote: > > #if defined(CONFIG_RANDOMIZE_BASE) > > - /* KASLR is enabled, disregard old_addr from user */ > > - func->old_addr = 0; > > + /* If KASLR has been enabled, adjust old_addr accordingly */ > > + if (kaslr_enabled()) > > + func->old_addr += klp_vmlinux_relocation_offset(); > > #endif > > Can we remove the #ifdef now? It would probably be better to have an > #ifdef in asm/setup.h for the kaslr_enabled() definition. If we do that, we force all architectures that support (now, or at any point in the future) live patching to provide kaslr_enabled(), klp_vmlinux_relocation_offset() (or however it will be called), etc (even if they don't care a bit about kASLR) I would like to avoid that; it seems really unnecessary maintainance overhead imposed on archs. Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/