Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751663AbbDZIpI (ORCPT ); Sun, 26 Apr 2015 04:45:08 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59633 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751420AbbDZIpD (ORCPT ); Sun, 26 Apr 2015 04:45:03 -0400 Date: Sun, 26 Apr 2015 10:42:21 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi@googlegroups.com, Mark Brown , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ARM: sunxi: spi: use proper errno when message is too long. Message-ID: <20150426084221.GE5627@lukather> References: <4c27d44b2bdd759424ce4a4b2e8f6abf5d5a6735.1430034797.git.hramrach@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KuLpqunXa7jZSBt+" Content-Disposition: inline In-Reply-To: <4c27d44b2bdd759424ce4a4b2e8f6abf5d5a6735.1430034797.git.hramrach@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2769 Lines: 85 --KuLpqunXa7jZSBt+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 25, 2015 at 09:21:07PM +0200, Michal Suchanek wrote: > Signed-off-by: Michal Suchanek No commit log? > --- > drivers/spi/spi-sun4i.c | 2 +- > drivers/spi/spi-sun6i.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c > index fbb0a4d..8238b4e 100644 > --- a/drivers/spi/spi-sun4i.c > +++ b/drivers/spi/spi-sun4i.c > @@ -176,7 +176,7 @@ static int sun4i_spi_transfer_one(struct spi_master *= master, > =20 > /* We don't support transfer larger than the FIFO */ > if (tfr->len > SUN4I_FIFO_DEPTH) > - return -EINVAL; > + return -EMSGSIZE; Is it still a thing? The patch to remove such limit hasn't been merged yet? > reinit_completion(&sspi->done); > sspi->tx_buf =3D tfr->tx_buf; > diff --git a/drivers/spi/spi-sun6i.c b/drivers/spi/spi-sun6i.c > index ac48f59..0f5dd91 100644 > --- a/drivers/spi/spi-sun6i.c > +++ b/drivers/spi/spi-sun6i.c > @@ -166,7 +166,7 @@ static int sun6i_spi_transfer_one(struct spi_master *= master, > =20 > /* We don't support transfer larger than the FIFO */ > if (tfr->len > SUN6I_FIFO_DEPTH) > - return -EINVAL; > + return -EMSGSIZE; Eventually, we should move to using DMA for these messages longer than the FIFO. I should post these patches. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --KuLpqunXa7jZSBt+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVPKTsAAoJEBx+YmzsjxAgNqAQAJoeeMSVKfxVPW3DyDwDbo7q cy5L0YS1ZZcVXyvZ8M6QBSQ5KUzfvBMk+afubrgWNnLikGTNnUdZGtZR6JgrXPpX fhz+4qrw4w2SwCdhcr86IF4biku3goaFhjQJ01RnS3zXTQbUTWZChbK+qov9iLjz LC6X6GpVlAIbTQQ/MF1h4/kvoLxAXjvhYrTEb/4+qw7wW7fvA1GaPCuwEHQsA86Q +5EEWTohZBKGMk2J+yP14v5NTNYGEr+3iKbTFLZFSvpaTH9zKeXY7DpTrg9Tdfz9 5EZgxNQztuS5n2ReDhf7/uPGKdOCr/hk9PS5aDP8xGXFJFicv1DWcC7fXieqiXup iizSEFRAPfE5TrsgevoP3zkI15Fk1tekDrfiw+sUtIupSEsMOhEKDf9NYHrWoGpe Q7KcKqxN4DCr/AdEHN8duwcuOC7FgDIw9DvpyaLvrGt0YGPgjfQ09+r+5uhfS7C8 gpaK8mwAkkqyoAOB/oYxyCQIk7fEcFf2DQao711WIcalZEMj8VhrLf7mkOdEPUpu 63ZfhXSEYRz7ofC8baUbFqppYW3cOJ5bRqxlpTkH8WeRgip8WdM8IfJtfar4Qz1i vEndzU960k1uTCmIeohzm3WXZ6jMs5vDme554mit0P7pDH1FJpyFHBQxPXnigazj eme+97SFVjJ8k2YiLx8o =E+jc -----END PGP SIGNATURE----- --KuLpqunXa7jZSBt+-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/