Message-ID: <553CAC58.8000707@amd.com>
Date: Sun, 26 Apr 2015 12:14:00 +0300
From: Oded Gabbay <oded.gabbay@amd.com>
Organization: AMD
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: <joro@8bytes.org>
CC: <iommu@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH] iommu/amd: Fix bug in put_pasid_state_wait
References: <1429193324-20398-1-git-send-email-oded.gabbay@amd.com>
In-Reply-To: <1429193324-20398-1-git-send-email-oded.gabbay@amd.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2015 09:14:59.7433
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR02MB193
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1395
Lines: 39

Hi Joerg,
Could you please take a look at this patch ?
I want it to be included in stable asap so Fedora 22 will pick it up.

Thanks,
	Oded

On 04/16/2015 05:08 PM, Oded Gabbay wrote:
> This patch fixes a bug in put_pasid_state_wait that appeared in kernel 4.0
> The bug is that pasid_state->count wasn't decremented before entering the
> wait_event. Thus, the condition in wait_event will never be true.
>
> The fix is to decrement (atomically) the pasid_state->count before the
> wait_event.
>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> Cc: stable@vger.kernel.org
> ---
>   drivers/iommu/amd_iommu_v2.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c
> index 6d5a5c4..173e70d 100644
> --- a/drivers/iommu/amd_iommu_v2.c
> +++ b/drivers/iommu/amd_iommu_v2.c
> @@ -266,6 +266,7 @@ static void put_pasid_state(struct pasid_state *pasid_state)
>
>   static void put_pasid_state_wait(struct pasid_state *pasid_state)
>   {
> +	atomic_dec(&pasid_state->count);
>   	wait_event(pasid_state->wq, !atomic_read(&pasid_state->count));
>   	free_pasid_state(pasid_state);
>   }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/