Message-ID: <553CC804.4050206@cogentembedded.com>
Date: Sun, 26 Apr 2015 14:12:04 +0300
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Yunzhi Li <lyz@rock-chips.com>, heiko@sntech.de
CC: gauravsh@google.com, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@arm.linux.org.uk>, hl@rock-chips.com,
        Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        devicetree@vger.kernel.org, alberto@google.com,
        linux-kernel@vger.kernel.org, yk@rock-chips.com,
        linux-rockchip@lists.infradead.org, Rob Herring <robh+dt@kernel.org>,
        Kumar Gala <galak@codeaurora.org>, cf@rock-chips.com,
        wulf@rock-chips.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly
 board
References: <1430041299-24874-1-git-send-email-lyz@rock-chips.com> <1430041299-24874-2-git-send-email-lyz@rock-chips.com>
In-Reply-To: <1430041299-24874-2-git-send-email-lyz@rock-chips.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 973
Lines: 35

Hello.

On 4/26/2015 12:41 PM, Yunzhi Li wrote:

> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode

> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

> ---

>   arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
>   1 file changed, 1 insertion(+)

> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi
> index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
>   };
>
>   &usb_otg {
> +	dr_modr = "host";

    You meant to type "dr_mode".

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/