Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbbDZMzS (ORCPT ); Sun, 26 Apr 2015 08:55:18 -0400 Received: from down.free-electrons.com ([37.187.137.238]:33783 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751144AbbDZMzF (ORCPT ); Sun, 26 Apr 2015 08:55:05 -0400 Date: Sun, 26 Apr 2015 14:52:20 +0200 From: Maxime Ripard To: Michal Suchanek Cc: linux-sunxi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , devicetree , "linux-arm-kernel@lists.infradead.org" , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] ARM: dts: sunxi: A10s Olinuxino add missing SPI and simplefb. Message-ID: <20150426125220.GG5627@lukather> References: <20150426083958.GD5627@lukather> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NPukt5Otb9an/u20" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3893 Lines: 109 --NPukt5Otb9an/u20 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 26, 2015 at 11:21:34AM +0200, Michal Suchanek wrote: > Hello, >=20 > On 26 April 2015 at 10:39, Maxime Ripard > wrote: > > Hi, > > > > On Mon, Mar 23, 2015 at 03:00:31PM +0100, Michal Suchanek wrote: > >> Signed-off-by: Michal Suchanek >=20 > >> &ohci0 { > >> status =3D "okay"; > >> }; > >> diff --git a/arch/arm/boot/dts/sun5i-a10s.dtsi b/arch/arm/boot/dts/sun= 5i-a10s.dtsi > >> index a78c95d..438eba1 100644 > >> --- a/arch/arm/boot/dts/sun5i-a10s.dtsi > >> +++ b/arch/arm/boot/dts/sun5i-a10s.dtsi > >> @@ -154,6 +154,20 @@ > >> clocks =3D <&apb1_gates 18>; > >> status =3D "disabled"; > >> }; > >> + > >> + spi2: spi@01c17000 { > >> + compatible =3D "allwinner,sun4i-a10-spi"; > >> + reg =3D <0x01c17000 0x1000>; > >> + interrupts =3D <12>; > >> + clocks =3D <&ahb_gates 22>, <&spi2_clk>; > >> + clock-names =3D "ahb", "mod"; > >> + dmas =3D <&dma SUN4I_DMA_DEDICATED 29>, > >> + <&dma SUN4I_DMA_DEDICATED 28>; > >> + dma-names =3D "rx", "tx"; > >> + status =3D "disabled"; > >> + #address-cells =3D <1>; > >> + #size-cells =3D <0>; > >> + }; > >> }; > >> }; > > > > This should be in sun5i.dtsi (and in a separate patch). > > > >> @@ -198,4 +212,18 @@ > >> allwinner,drive =3D ; > >> allwinner,pull =3D ; > >> }; > >> + > >> + spi2_pins_a: spi2@0 { > >> + allwinner,pins =3D "PB11", "PB12", "PB13", "PB14"; > >> + allwinner,function =3D "spi2"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> + > >> + spi2_pins_b: spi2@1 { > >> + allwinner,pins =3D "PE00", "PE01", "PE02", "PE03"; > >> + allwinner,function =3D "spi2"; > >> + allwinner,drive =3D ; > >> + allwinner,pull =3D ; > >> + }; > >> }; > > > > Ditto. > > >=20 > A13 does not have these pins so maybe not? A13 has the PE* pins, but yeah, that's true for the first group. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --NPukt5Otb9an/u20 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVPN+EAAoJEBx+YmzsjxAgIAoQAJbLa6giV20CMUhtZXQ7MR44 Fkiq2GktF2J4o6zsgpU6k5cQ6QNmEZxdX+sWmH/M8ySe8h3W3qccC17IUt5vzxsc iA8goS65uzyRaJingcgQbCOzMjrHo8A4M5mo4QdxDQCAUMCsN3vJi+h56RGNSHY0 UCLY1cqJJQeGoyH5EYZoHUnw+mTIKkMatMB+IHmDj21wVsOwwNuWEEf7D6MK5BkV pbiQEE1ImG4xVj9YutjcXFHrkmQVl5ShgJ97T9cCLuAYcHzSSfUqFX69cVYk5aF8 CfMRmz8GJXOO6cPQ8e6RkPY6/6pUI6aBzoQGqiCBfKYnB7C5cLuHKfTfZ2MUdjyq 27NdgfbMoXaEby9pcapCidrHh1NfCjyCgVLdwfG3GxpyRuMxJbOj3eZc8yn7jCLv veO36k+K06hQ/YADorwOquNSsFgWOAu9l3i3hbqc/avQgrEnIIp65BaN0/UxwCLh hx/dhOJq1Ijix2XgOi3X4zxgjSCO12R/bOJqrbkOxfaGRPCbyB7TXd2yORpmBvap OLIE7zlapz3h4kgVmuH8sOGO8zfCUJmnxnGpJtsi/WBMaakIR8PxnCfPCLbj7KAO OafAFSleKQ4y/3O6r9kqmGXtTPV/8RdoOhXbo2GCbYcpPcPH7WTeShChCGJKzAn/ qdf34ByTBY8sddBlUMQW =YAyM -----END PGP SIGNATURE----- --NPukt5Otb9an/u20-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/