Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbbDZQe3 (ORCPT ); Sun, 26 Apr 2015 12:34:29 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:35024 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbDZQeZ (ORCPT ); Sun, 26 Apr 2015 12:34:25 -0400 Date: Sun, 26 Apr 2015 18:37:25 +0200 From: Alexander Hirsch <1zeeky@gmail.com> To: Paul Bolle Cc: linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] x86/microcode: Allow early loading without initrd Message-ID: <20150426183725.05d5acc7@netblarch.fritz.box> In-Reply-To: <1430062273.2927.121.camel@x220> References: <20150426170314.210e921c@netblarch.fritz.box> <1430062273.2927.121.camel@x220> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3380 Lines: 110 On Sun, 26 Apr 2015 17:31:13 +0200 Paul Bolle wrote: > #ifndef CONFIG_BLK_DEV_INITRD? Indeed, thank you. I fixed it. --- From: Alexander 'z33ky' Hirsch <1zeeky@gmail.com> Date: Sun, 26 Apr 2015 15:18:18 +0200 Subject: [PATCH] x86, microcode: Allow early loading without initrd Microcode can be baked into the kernel image via CONFIG_EXTRA_FIRMWARE and the early loader supports that, but still depended on BLK_DEV_INITRD. This dependency is removed. Signed-off-by: Alexander Hirsch <1zeeky@gmail.com> --- arch/x86/Kconfig | 2 +- arch/x86/kernel/cpu/microcode/intel_early.c | 30 +++++++++++++++++++++-------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 226d569..bc7e187 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -1144,7 +1144,7 @@ config MICROCODE_AMD_EARLY config MICROCODE_EARLY bool "Early load microcode" - depends on MICROCODE=y && BLK_DEV_INITRD + depends on MICROCODE=y select MICROCODE_INTEL_EARLY if MICROCODE_INTEL select MICROCODE_AMD_EARLY if MICROCODE_AMD default y diff --git a/arch/x86/kernel/cpu/microcode/intel_early.c b/arch/x86/kernel/cpu/microcode/intel_early.c index 98d320c..ad7901f 100644 --- a/arch/x86/kernel/cpu/microcode/intel_early.c +++ b/arch/x86/kernel/cpu/microcode/intel_early.c @@ -691,6 +691,9 @@ int __init save_microcode_in_initrd_intel(void) unsigned int count = mc_saved_data.mc_saved_count; struct microcode_intel *mc_saved[MAX_UCODE_COUNT]; int ret = 0; +#ifndef CONFIG_BLK_DEV_INITRD + unsigned long initrd_start = 0; +#endif if (count == 0) return ret; @@ -728,24 +731,32 @@ _load_ucode_intel_bsp(struct mc_saved_data *mc_saved_data, void __init load_ucode_intel_bsp(void) { - u64 start, size; + u64 start = 0, size = 0; + struct mc_saved_data *mc_saved_data_p; + unsigned long *mc_saved_in_initrd_p; +#ifdef CONFIG_BLK_DEV_INITRD #ifdef CONFIG_X86_32 struct boot_params *p; p = (struct boot_params *)__pa_nodebug(&boot_params); start = p->hdr.ramdisk_image; size = p->hdr.ramdisk_size; - - _load_ucode_intel_bsp( - (struct mc_saved_data *)__pa_nodebug(&mc_saved_data), - (unsigned long *)__pa_nodebug(&mc_saved_in_initrd), - start, size); #else start = boot_params.hdr.ramdisk_image + PAGE_OFFSET; size = boot_params.hdr.ramdisk_size; - - _load_ucode_intel_bsp(&mc_saved_data, mc_saved_in_initrd, start, size); #endif +#endif + +#ifdef CONFIG_X86_32 + mc_saved_in_initrd_p = + (unsigned long *)__pa_nodebug(mc_saved_in_initrd); + mc_saved_data_p = (struct mc_saved_data *)__pa_nodebug(&mc_saved_data); +#else + mc_saved_data_p = &mc_saved_data; + mc_saved_in_initrd_p = mc_saved_in_initrd; +#endif + + _load_ucode_intel_bsp(mc_saved_data_p, mc_saved_in_initrd_p, start, size); } void load_ucode_intel_ap(void) @@ -755,6 +766,9 @@ void load_ucode_intel_ap(void) unsigned long *mc_saved_in_initrd_p; unsigned long initrd_start_addr; enum ucode_state ret; +#ifndef CONFIG_BLK_DEV_INITRD + unsigned long initrd_start = 0; +#endif #ifdef CONFIG_X86_32 unsigned long *initrd_start_p; -- 2.3.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/