Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbbDZRBi (ORCPT ); Sun, 26 Apr 2015 13:01:38 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:41701 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbbDZRBg (ORCPT ); Sun, 26 Apr 2015 13:01:36 -0400 Message-ID: <553D19EE.4070404@kernel.org> Date: Sun, 26 Apr 2015 18:01:34 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Karol Wrona , linux-iio@vger.kernel.org CC: linux-kernel@vger.kernel.org, Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , Karol Wrona Subject: Re: [PATCH] iio: common: ssp_sensors: Fix uninitialized warning for timestamp References: <1429176624-19223-1-git-send-email-k.wrona@samsung.com> <5532AA55.3040609@kernel.org> <553A2499.30501@samsung.com> In-Reply-To: <553A2499.30501@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2114 Lines: 56 On 24/04/15 12:10, Karol Wrona wrote: > On 04/18/2015 09:02 PM, Jonathan Cameron wrote: >> On 16/04/15 10:30, Karol Wrona wrote: >>> calculated_time variable caused warning as uninitialized. It was not harmful >>> because it was evaluated in the path in which was used later but it is to >>> satisfy the checkers. >>> >>> Signed-off-by: Karol Wrona >> Dumb compiler. It's a false positive and as the function is an inline in the header, >> it should be able to tell. >> >> What compiler is spitting out the warning? > > > You should have krobot complain in the mail. > Subject: "include/linux/iio/buffer.h:142:32: warning: 'calculated_time' > may be used uninitialized in this function" > > This was sh compiler. I suppose that we can treat it as false warning. > It will complain whenever the variable will stay uninitialized even if > not used in such path. Yup. Seems false to me. Could report it if you are really bored :) > > >> >>> --- >>> drivers/iio/common/ssp_sensors/ssp_iio.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/iio/common/ssp_sensors/ssp_iio.c b/drivers/iio/common/ssp_sensors/ssp_iio.c >>> index a3ae165..16180e6 100644 >>> --- a/drivers/iio/common/ssp_sensors/ssp_iio.c >>> +++ b/drivers/iio/common/ssp_sensors/ssp_iio.c >>> @@ -80,7 +80,7 @@ int ssp_common_process_data(struct iio_dev *indio_dev, void *buf, >>> unsigned int len, int64_t timestamp) >>> { >>> __le32 time; >>> - int64_t calculated_time; >>> + int64_t calculated_time = 0; >>> struct ssp_sensor_data *spd = iio_priv(indio_dev); >>> >>> if (indio_dev->scan_bytes == 0) >>> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/