Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbbDZSmy (ORCPT ); Sun, 26 Apr 2015 14:42:54 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:42494 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbbDZSmx (ORCPT ); Sun, 26 Apr 2015 14:42:53 -0400 Message-ID: <553D31AB.7000004@kernel.org> Date: Sun, 26 Apr 2015 19:42:51 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Irina Tirdea , linux-iio@vger.kernel.org, Hartmut Knaack CC: linux-kernel@vger.kernel.org, Vlad Dogaru Subject: Re: [PATCH v2 04/17] iio: accel: mma9553: add enable channel for activity References: <1428939664-12503-1-git-send-email-irina.tirdea@intel.com> <1428939664-12503-5-git-send-email-irina.tirdea@intel.com> In-Reply-To: <1428939664-12503-5-git-send-email-irina.tirdea@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1615 Lines: 39 On 13/04/15 16:40, Irina Tirdea wrote: Err, this first bit is not relevant to this patch so I've dropped it. > Since we need to specifically power on the device if used > in polling mode, we have an enable channel for each type > (step count, distance, speed, calories, etc.). > > Add also an enable channel for activity, so it can also > be polled independently of events or other channels. > > Signed-off-by: Irina Tirdea > Reported-by: Daniel Baluta Applied to the fixes-togreg branch of iio.git Thanks, > --- > drivers/iio/accel/mma9553.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c > index 03120fb..365a109 100644 > --- a/drivers/iio/accel/mma9553.c > +++ b/drivers/iio/accel/mma9553.c > @@ -972,7 +972,8 @@ static const struct iio_chan_spec_ext_info mma9553_ext_info[] = { > .modified = 1, \ > .channel2 = _chan2, \ > .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \ > - .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_CALIBHEIGHT), \ > + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_CALIBHEIGHT) | \ > + BIT(IIO_CHAN_INFO_ENABLE), \ > .event_spec = mma9553_activity_events, \ > .num_event_specs = ARRAY_SIZE(mma9553_activity_events), \ > .ext_info = mma9553_ext_info, \ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/