Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751170AbbDZVTO (ORCPT ); Sun, 26 Apr 2015 17:19:14 -0400 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:41635 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbbDZVTM (ORCPT ); Sun, 26 Apr 2015 17:19:12 -0400 Message-ID: <1430083148.2411.15.camel@x220> Subject: Re: [PATCH] kconfig: add tinfo library if it exists to lxdialog linking flags From: Paul Bolle To: sylvain.bertrand@gmail.com Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 26 Apr 2015 23:19:08 +0200 In-Reply-To: <20150425160546.GA4002@freedom> References: <20150425160546.GA4002@freedom> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1647 Lines: 49 On Sat, 2015-04-25 at 16:05 +0000, sylvain.bertrand@gmail.com wrote: > HOSTLD scripts/kconfig/mconf > /bin/ld: scripts/kconfig/lxdialog/checklist.o: undefined reference to symbol 'acs_map' > > Add tinfo library to lxdiablog linking flags, if it exists. > > Signed-off-by: Sylvain BERTRAND > --- > --- a/scripts/kconfig/lxdialog/check-lxdialog.sh > +++ b/scripts/kconfig/lxdialog/check-lxdialog.sh > @@ -4,6 +4,9 @@ > # What library to link > ldflags() > { > + # Some ncurses symbols are in tinfo library, if it exists > + pkg-config --libs tinfow 2>/dev/null > + pkg-config --libs tinfo 2>/dev/null > pkg-config --libs ncursesw 2>/dev/null && exit > pkg-config --libs ncurses 2>/dev/null && exit > for ext in so a dll.a dylib ; do It looks like commit fc9c6e000f62 ("menuconfig: optionally use pkg-config to detect ncurses libs") claims to already fix this. And your patch is obviously done on top of that commit. So I did some further, well, research. That is: I skimmed man pkg-config and stared a bit at the pkg-config related files shipped with ncurses-devel (for Fedora 20). And to me it seems pkg-config --libs ncursesw or pkg-config --libs ncurses should already add -ltinfow or -ltinfo if those flags would be needed, just like that commit implies. Is that how pkg-config should work? If so, I wonder why it fails for you. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/