Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbbD0EcL (ORCPT ); Mon, 27 Apr 2015 00:32:11 -0400 Received: from senator.holtmann.net ([87.106.208.187]:40531 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbbD0EcH convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2015 00:32:07 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\)) Subject: Re: [PATCH 1/1] Documentation: Add dt-binding for TI-btwilink driver From: Marcel Holtmann In-Reply-To: <1430106433-7132-1-git-send-email-gigi.joseph@ti.com> Date: Sun, 26 Apr 2015 21:31:58 -0700 Cc: devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, Gigi Joseph Content-Transfer-Encoding: 8BIT Message-Id: References: <1430106433-7132-1-git-send-email-gigi.joseph@ti.com> To: Gigi Joseph X-Mailer: Apple Mail (2.2098) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1723 Lines: 45 Hi Gigi, > btwilink binds bluetooth hci0 interface with the shared transport driver > > Signed-off-by: Gigi Joseph > --- > Documentation/devicetree/bindings/btwilink.txt | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > create mode 100644 Documentation/devicetree/bindings/btwilink.txt > > diff --git a/Documentation/devicetree/bindings/btwilink.txt b/Documentation/devicetree/bindings/btwilink.txt > new file mode 100644 > index 0000000..d286aea > --- /dev/null > +++ b/Documentation/devicetree/bindings/btwilink.txt > @@ -0,0 +1,15 @@ > +btwilink > +-------- > + > +Required properties: > + > + - compatible : must be "ti,btwilink" > + > +Example: > + > +Enable the btwilink driver to bind the bluetooth hci0 interface with > +ti-st shared transport driver > + > +btwilink { > + compatible = "ti,btwilink"; > +}; actually I wonder if someone finally starts re-writing the TI-ST driver to integrate with the new Bluetooth subsystem features (like hdev->setup, __hci_cmd_sync and h4_recv_buf) so that this complicated setup is no longer needed. I do not think we actually would need a shared transport at all. We should have a Bluetooth HCI driver that can have children for FM radio and GPS exposed. Exposing proper platform devices with Bluetooth HCI as parent makes sense. The shared transport is not really a parent. First and foremost, this is a Bluetooth chip. The FM radio and GPS features are just glued on top of it. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/