Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932392AbbD0Hlp (ORCPT ); Mon, 27 Apr 2015 03:41:45 -0400 Received: from mga01.intel.com ([192.55.52.88]:2606 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932113AbbD0Hlm (ORCPT ); Mon, 27 Apr 2015 03:41:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,655,1422950400"; d="scan'208";a="716154828" From: Jani Nikula To: Fabian Frederick , linux-kernel@vger.kernel.org Cc: Fabian Frederick , Daniel Vetter , David Airlie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/1 linux-next] drm/i915: use ERR_CAST instead of ERR_PTR/PTR_ERR In-Reply-To: <1429954470-28430-1-git-send-email-fabf@skynet.be> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1429954470-28430-1-git-send-email-fabf@skynet.be> User-Agent: Notmuch/0.19+87~gcf99a78 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 27 Apr 2015 10:43:19 +0300 Message-ID: <87fv7mc8yw.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 36 On Sat, 25 Apr 2015, Fabian Frederick wrote: > Inspired by scripts/coccinelle/api/err_cast.cocci > > Signed-off-by: Fabian Frederick Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h > index 897f17d..d52f267 100644 > --- a/drivers/gpu/drm/i915/intel_drv.h > +++ b/drivers/gpu/drm/i915/intel_drv.h > @@ -1310,7 +1310,7 @@ intel_atomic_get_crtc_state(struct drm_atomic_state *state, > struct drm_crtc_state *crtc_state; > crtc_state = drm_atomic_get_crtc_state(state, &crtc->base); > if (IS_ERR(crtc_state)) > - return ERR_PTR(PTR_ERR(crtc_state)); > + return ERR_CAST(crtc_state); > > return to_intel_crtc_state(crtc_state); > } > -- > 1.9.1 > -- Jani Nikula, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/