Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932476AbbD0HpY (ORCPT ); Mon, 27 Apr 2015 03:45:24 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:36814 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932161AbbD0HpU (ORCPT ); Mon, 27 Apr 2015 03:45:20 -0400 From: Rasmus Villemoes To: Daniel Wagner Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/sort: Add 64 bit swap function Organization: D03 References: <1430119606-25012-1-git-send-email-daniel.wagner@bmw-carit.de> X-Hashcash: 1:20:150427:akpm@linux-foundation.org::mQbxT1oVGbId5EwB:00000000000000000000000000000000000021hg X-Hashcash: 1:20:150427:daniel.wagner@bmw-carit.de::7cFGgh2rTV7chgXl:000000000000000000000000000000000001lUz X-Hashcash: 1:20:150427:linux-kernel@vger.kernel.org::XPK5qNLWkaMvz9Xy:0000000000000000000000000000000002UV6 Date: Mon, 27 Apr 2015 09:45:18 +0200 In-Reply-To: <1430119606-25012-1-git-send-email-daniel.wagner@bmw-carit.de> (Daniel Wagner's message of "Mon, 27 Apr 2015 09:26:46 +0200") Message-ID: <87k2wyypyp.fsf@rasmusvillemoes.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1007 Lines: 32 On Mon, Apr 27 2015, Daniel Wagner wrote: > static int cmp_32(const void *a, const void *b) > { > return (int) (*(u32 *)a - *(u32 *)b); > } > > static int cmp_64(const void *a, const void *b) > { > return (int) (*(u64 *)a - *(u64 *)b); > } > Please [1] don't [2] do [3] this [4]. [1] acbbe6fbb240a927ee1f5994f04d31267d422215 kcmp: fix standard comparison bug [2] ef17af2a817db97d42dd2ec0a425231748e23dbc fs: nfsd: Fix signedness bug in compare_blob [3] ddbc22e27e672b6b180757ea1d7f8481dbb88128 fs/hfs/catalog.c: fix comparison bug in hfs_cat_keycmp [4] 72392ed0eb6fde96826cb9d66bd4f50a7ba61450 kernfs: Fix kernfs_name_compare (sorry for not actually looking at the patch - this just triggered one of my pet peeves). Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/