Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932536AbbD0JJK (ORCPT ); Mon, 27 Apr 2015 05:09:10 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:49156 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932507AbbD0JJH (ORCPT ); Mon, 27 Apr 2015 05:09:07 -0400 From: Arnd Bergmann To: Tobias Klauser Cc: Yoshinori Sato , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v9 01/17] h8300: Assembly headers. Date: Mon, 27 Apr 2015 09:48:39 +0200 Message-ID: <4430626.HbYtNkMCT0@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150427074241.GA11048@distanz.ch> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-2-git-send-email-ysato@users.sourceforge.jp> <20150427074241.GA11048@distanz.ch> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:sn18iiCL9bIO7BMHBndD1NtMmJP4BlUCkUcBQyDc2hzO1RLU+Gp 9X8e93e8H1KPXqL+p0RWvNi05SxGnfSKtfeDCOnWTaxj4THMMZO1hln7mynU3/mxK9Al6JY 4m+VxKoeZzGmEhOG8hw/kyesJO0VRj5hC2nq1qNozKKNylbv4TwUANE/lXSrzUrjG1GubZM xNt0oHgR4GEIiVGgwymgw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1468 Lines: 43 On Monday 27 April 2015 09:42:41 Tobias Klauser wrote: > > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > > new file mode 100644 > > index 0000000..09031d0 > > --- /dev/null > > +++ b/arch/h8300/include/asm/elf.h > > @@ -0,0 +1,101 @@ > > +#ifndef __ASM_H8300_ELF_H > > +#define __ASM_H8300_ELF_H > > + > > +/* > > + * ELF register definitions.. > > + */ > > + > > +#include > > +#include > > + > > +typedef unsigned long elf_greg_t; > > + > > +#define ELF_NGREG (sizeof(struct user_regs_struct) / sizeof(elf_greg_t)) > > +typedef elf_greg_t elf_gregset_t[ELF_NGREG]; > > +typedef unsigned long elf_fpregset_t; > > + > > +/* > > + * This is used to ensure we don't load something for the wrong architecture. > > + */ > > +#define elf_check_arch(x) ((x)->e_machine == EM_H8_300) > > EM_H8_300 is still used before it is introduced in patch 15/17, please > change the patch order. Otherwise you break bisectability. While that is true in principle, I really wouldn't care about that when introducing a new architecture: There is no way to use this code unless you introduce all code first. For any later add-ons, bisectability should of course be maintained. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/