From: Arnd Bergmann <arnd@arndb.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v9 07/17] h8300: miscellaneous functions
Date: Mon, 27 Apr 2015 10:57:10 +0200
Message-ID: <2426012.sTXZYqKJ88@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1430112924-1134-8-git-send-email-ysato@users.sourceforge.jp>
References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-8-git-send-email-ysato@users.sourceforge.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1297
Lines: 40

On Monday 27 April 2015 14:35:14 Yoshinori Sato wrote:
> +void dma_sync_single_for_device(struct device *dev, dma_addr_t handle,
> +				size_t size, enum dma_data_direction dir)
> +{
> +}
> +EXPORT_SYMBOL(dma_sync_single_for_device);
> +
> +void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg,
> +			    int nents, enum dma_data_direction dir)
> +{
> +	int i;
> +
> +	for (i = 0; i < nents; sg++, i++)
> +		dma_sync_single_for_device(dev, sg->dma_address,
> +					   sg->length, dir);
> +}
> +EXPORT_SYMBOL(dma_sync_sg_for_device);
> +
> +dma_addr_t dma_map_single(struct device *dev, void *addr, size_t size,
> +			  enum dma_data_direction dir)
> +{
> +	dma_addr_t handle = virt_to_bus(addr);
> +
> +	dma_sync_single_for_device(dev, handle, size, dir);
> +	return handle;
> +}
> +EXPORT_SYMBOL(dma_map_single);


As this all doesn't do anything, and your dma-mapping.h header explains
that the architecture is cache-coherent, just remove these functions,
and replace them with empty 'static inline' helpers in that header.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/