From: Arnd Bergmann <arnd@arndb.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
        Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v9 00/17] Re-introduce h8300 architecture
Date: Mon, 27 Apr 2015 11:11:28 +0200
Message-ID: <4238542.6HRp7rHay7@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp>
References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1093
Lines: 29

On Monday 27 April 2015 14:35:07 Yoshinori Sato wrote:
> Hello.
> I will re-introducing h8300.
> 

I've done one more pass through all of your code. Generally I think you
should at this point ask Stephen Rothwell to add your git tree to linux-next,
and not rewrite the patches any more but instead add patches on top to fix
the remaining issues.

My comments are in several areas:

- device initialization. This should be updated to use a more modern version
  and replace the use of early_platform and static platform_device definitions.

- asm/io.h needs should be rethought

- header files that are functionally identical to the asm-generic variant
  and could be replaced with a 'generic-y' Makefile statement

I think all of these should be addressed, but they are not big issues that
would stop you from merging the code in linux-4.2.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/