Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932424AbbD0J01 (ORCPT ); Mon, 27 Apr 2015 05:26:27 -0400 Received: from sym2.noone.org ([178.63.92.236]:44047 "EHLO sym2.noone.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752490AbbD0J0Z (ORCPT ); Mon, 27 Apr 2015 05:26:25 -0400 Date: Mon, 27 Apr 2015 11:26:22 +0200 From: Tobias Klauser To: Arnd Bergmann Cc: Yoshinori Sato , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v9 01/17] h8300: Assembly headers. Message-ID: <20150427092622.GD11048@distanz.ch> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-2-git-send-email-ysato@users.sourceforge.jp> <20150427074241.GA11048@distanz.ch> <4430626.HbYtNkMCT0@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4430626.HbYtNkMCT0@wuerfel> X-Editor: Vi IMproved 7.3 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 45 On 2015-04-27 at 09:48:39 +0200, Arnd Bergmann wrote: > On Monday 27 April 2015 09:42:41 Tobias Klauser wrote: > > > diff --git a/arch/h8300/include/asm/elf.h b/arch/h8300/include/asm/elf.h > > > new file mode 100644 > > > index 0000000..09031d0 > > > --- /dev/null > > > +++ b/arch/h8300/include/asm/elf.h > > > @@ -0,0 +1,101 @@ > > > +#ifndef __ASM_H8300_ELF_H > > > +#define __ASM_H8300_ELF_H > > > + > > > +/* > > > + * ELF register definitions.. > > > + */ > > > + > > > +#include > > > +#include > > > + > > > +typedef unsigned long elf_greg_t; > > > + > > > +#define ELF_NGREG (sizeof(struct user_regs_struct) / sizeof(elf_greg_t)) > > > +typedef elf_greg_t elf_gregset_t[ELF_NGREG]; > > > +typedef unsigned long elf_fpregset_t; > > > + > > > +/* > > > + * This is used to ensure we don't load something for the wrong architecture. > > > + */ > > > +#define elf_check_arch(x) ((x)->e_machine == EM_H8_300) > > > > EM_H8_300 is still used before it is introduced in patch 15/17, please > > change the patch order. Otherwise you break bisectability. > > While that is true in principle, I really wouldn't care about that > when introducing a new architecture: There is no way to use this > code unless you introduce all code first. Agreed. But should the ELF machine at least be introduced before the build infrastructure (patch 10/17) is added? Otherwise we're able to compile the new arch port in principle but it will fail due to the missing definition. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/