Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753005AbbD0JoD (ORCPT ); Mon, 27 Apr 2015 05:44:03 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:37893 "EHLO e06smtp13.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752726AbbD0JoA (ORCPT ); Mon, 27 Apr 2015 05:44:00 -0400 Date: Mon, 27 Apr 2015 11:43:53 +0200 From: Michael Mueller To: Christian Borntraeger Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Habkost , Gleb Natapov , Alexander Graf , Daniel Hansel , "Jason J. Herne" , Cornelia Huck , Paolo Bonzini , Richard Henderson , Andreas Faerber Subject: Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models Message-ID: <20150427114353.0386c3eb@bee> In-Reply-To: <553DF033.1060405@de.ibm.com> References: <1428933396-37887-1-git-send-email-mimu@linux.vnet.ibm.com> <1428933396-37887-12-git-send-email-mimu@linux.vnet.ibm.com> <553DF033.1060405@de.ibm.com> Organization: IBM X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15042709-0013-0000-0000-000003CA38AD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2501 Lines: 86 On Mon, 27 Apr 2015 10:15:47 +0200 Christian Borntraeger wrote: > Am 13.04.2015 um 15:56 schrieb Michael Mueller: > [...] > > +static int cpu_model_get(KVMState *s, uint64_t attr, uint64_t addr) > > +{ > > + int rc = -ENOSYS; > > + struct kvm_device_attr dev_attr = { > > + .group = KVM_S390_VM_CPU_MODEL, > > + .attr = attr, > > + .addr = addr, > > Would it make sense to do the cast here.... cpu_model_get/set() is used to handle both attributes, KVM_S390_VM_CPU_MACHINE and KVM_S390_VM_CPU_PROCESSOR. Both require a different type in the signature, (S390ProcessorProps*) and (S390MachineProps*). Adding both as parameters seems to be odd and would require additionally logic in the function. Thus I think doing the cast outside is just the right thing to do. Michael > > + }; > > + > > + if (kvm_vm_check_attr(s, dev_attr.group, dev_attr.attr)) { > > + rc = kvm_vm_ioctl(s, KVM_GET_DEVICE_ATTR, &dev_attr); > > + } > > + > > + return rc; > > +} > > + > > +static int cpu_model_set(KVMState *s, uint64_t attr, uint64_t addr) > > +{ > > + int rc = -ENOSYS; > > + struct kvm_device_attr dev_attr = { > > + .group = KVM_S390_VM_CPU_MODEL, > > + .attr = attr, > > + .addr = addr, > > ...and here... > > > + }; > > + > > + if (kvm_vm_check_attr(s, dev_attr.group, dev_attr.attr)) { > > + rc = kvm_vm_ioctl(s, KVM_SET_DEVICE_ATTR, &dev_attr); > > + } > > + > > + return rc; > > +} > > + > > +static int kvm_s390_get_machine_props(KVMState *s, S390MachineProps *prop) > > +{ > > + int rc = -EFAULT; > > + > > + if (s) { > > + rc = cpu_model_get(s, KVM_S390_VM_CPU_MACHINE, (uint64_t) prop); > > and pass S390MachineProps as 3rd parameter? > > > > +int kvm_s390_get_processor_props(S390ProcessorProps *prop) > > +{ > > + int rc; > > + > > + rc = cpu_model_get(kvm_state, KVM_S390_VM_CPU_PROCESSOR, (uint64_t) prop); > > dito > > + trace_kvm_get_processor_props(rc, prop->cpuid, prop->ibc); > > + return rc; > > +} > > + > > +int kvm_s390_set_processor_props(S390ProcessorProps *prop) > > +{ > > + int rc; > > + > > + rc = cpu_model_set(kvm_state, KVM_S390_VM_CPU_PROCESSOR, (uint64_t) prop); > > dito -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/