Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932745AbbD0NAT (ORCPT ); Mon, 27 Apr 2015 09:00:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:49644 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752967AbbD0NAQ convert rfc822-to-8bit (ORCPT ); Mon, 27 Apr 2015 09:00:16 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,657,1422950400"; d="scan'208";a="562445280" From: "Nicolae, Anda-maria" To: Paul Bolle CC: "sre@kernel.org" , "dbaryshkov@gmail.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "dwmw2@infradead.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: RE: [PATCH] power_supply: Add support for Richtek rt9455 battery charger Thread-Topic: [PATCH] power_supply: Add support for Richtek rt9455 battery charger Thread-Index: AQHQfzY2WKTPlgb780GKsnLE6kC9x51g1Y+V Date: Mon, 27 Apr 2015 13:00:11 +0000 Message-ID: <11982715D62E664DBACA4351A418B0581437DA44@IRSMSX107.ger.corp.intel.com> References: <1429862240-21619-1-git-send-email-anda-maria.nicolae@intel.com>,<1429952401.2927.91.camel@x220> In-Reply-To: <1429952401.2927.91.camel@x220> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.3.86.137] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 47 Hello Paul, Thanks for feedback :). I understand. I will change the license to GPL. Thanks, Anda ________________________________________ From: Paul Bolle [pebolle@tiscali.nl] Sent: Saturday, April 25, 2015 12:00 PM To: Nicolae, Anda-maria Cc: sre@kernel.org; dbaryshkov@gmail.com; robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk; galak@codeaurora.org; dwmw2@infradead.org; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org Subject: Re: [PATCH] power_supply: Add support for Richtek rt9455 battery charger Just a single nit: a license mismatch. On Fri, 2015-04-24 at 10:57 +0300, Anda-Maria Nicolae wrote: > --- /dev/null > +++ b/drivers/power/rt9455_charger.c > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. This states the license is GPL v2 or later. > +MODULE_LICENSE("GPL v2"); And, according to include/linux/module.h, this states the license is (only) GPL v2. So I think either the license comment or the ident used in the MODULE_LICENSE() macro should be changed. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/