Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932969AbbD0ONy (ORCPT ); Mon, 27 Apr 2015 10:13:54 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:47468 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932872AbbD0ONr (ORCPT ); Mon, 27 Apr 2015 10:13:47 -0400 Date: Mon, 27 Apr 2015 16:13:39 +0200 From: Michael Grzeschik To: Joe Perches Cc: netdev@vger.kernel.org, davem@davemloft.net, kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 06/21] ARCNET: com20020: remove unneeded macros Message-ID: <20150427141339.GB23151@pengutronix.de> References: <1429896055-31680-1-git-send-email-m.grzeschik@pengutronix.de> <1429896055-31680-7-git-send-email-m.grzeschik@pengutronix.de> <1429916685.23327.32.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429916685.23327.32.camel@perches.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 16:12:01 up 42 days, 2:03, 87 users, load average: 1.04, 1.16, 1.18 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mgr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1128 Lines: 28 On Fri, Apr 24, 2015 at 04:04:45PM -0700, Joe Perches wrote: > On Fri, 2015-04-24 at 19:20 +0200, Michael Grzeschik wrote: > > The macros SET_SUBADR, ARCRESET, ARCRESET0, ACOMMAND, ASTATUS, AINTMASK > > and ADIAGSTATUS are unnecessary indirections to the use of registers. > > This patch removes them and improves the readability of the code. > > This breaks compilation. > > Please compile test your patches before sending them. Sorry, but I can not reproduce this break. What was your base you applied this series on? Can you send me the failure you get? Thanks, Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/