Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753236AbbD0PvX (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Apr 2015 11:51:23 -0400
Received: from mail-oi0-f49.google.com ([209.85.218.49]:33981 "EHLO
	mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753218AbbD0PvW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Apr 2015 11:51:22 -0400
MIME-Version: 1.0
In-Reply-To: <1429887923.5211.6.camel@mm-sol.com>
References: <1429742451-11465-1-git-send-email-mathieu.poirier@linaro.org>
	<1429742451-11465-2-git-send-email-mathieu.poirier@linaro.org>
	<1429887923.5211.6.camel@mm-sol.com>
Date: Mon, 27 Apr 2015 09:51:21 -0600
Message-ID: <CANLsYkxWaxWL6rDaEKh+EOcXVBEqWp1W5yarSEsvEC3B0mne7g@mail.gmail.com>
Subject: Re: [PATCH 01/11] coresight-etm4x: Adding CoreSight ETM4x driver
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        linux-api@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kaixu Xia <kaixu.xia@linaro.org>,
        Chunyan Zhang <zhang.chunyan@linaro.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1787
Lines: 59

On 24 April 2015 at 09:05, Ivan T. Ivanov <iivanov@mm-sol.com> wrote:
>
> On Wed, 2015-04-22 at 16:40 -0600, Mathieu Poirier wrote:
>> From: Pratik Patel <pratikp@codeaurora.org>
>>
>> This driver manages the CoreSight ETMv4 (Embedded Trace Macrocell) IP block
>> to support HW assisted tracing on ARMv7 and ARMv8 architectures.
>>
>> Signed-off-by: Pratik Patel <pratikp@codeaurora.org>
>> Signed-off-by: Kaixu Xia <xiakaixu@huawei.com>
>> Signed-off-by: Mathieu Poirier poirier@linaro.org>
>
> <snip>
>
>>
>
>> +       pm_runtime_put(&adev->dev);
>> +
>> +       desc->type = CORESIGHT_DEV_TYPE_SOURCE;
>> +       desc->subtype.source_subtype = CORESIGHT_DEV_SUBTYPE_SOURCE_PROC;
>> +       desc->ops = &etm4_cs_ops;
>> +       desc->pdata = pdata;
>> +       desc->dev = dev;
>> +       desc->groups = coresight_etmv4_groups;
>> +       drvdata->csdev = coresight_register(desc);
>> +       if (IS_ERR(drvdata->csdev)) {
>> +               ret = PTR_ERR(drvdata->csdev);
>> +               goto err_arch_supported;
>
> double runtime put.

Good catch - thanks.

>
>> +       }
>> +
>> +       dev_info(dev, "%s initialized\n", (char *)id->data);
>> +
>> +       if (boot_enable) {
>> +               coresight_enable(drvdata->csdev);
>> +               drvdata->boot_enable = true;
>> +       }
>> +
>> +       return 0;
>> +
>> +err_arch_supported:
>> +       pm_runtime_put(&adev->dev);
>> +       if (--etm4_count == 0)
>> +               unregister_hotcpu_notifier(&etm4_cpu_notifier);
>> +       return ret;
>> +}
>
> Regards,
> Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/