Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753157AbbD0R7n (ORCPT ); Mon, 27 Apr 2015 13:59:43 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:34638 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753040AbbD0R7l (ORCPT ); Mon, 27 Apr 2015 13:59:41 -0400 MIME-Version: 1.0 In-Reply-To: <1430132450-4496-1-git-send-email-niklass@axis.com> References: <1430132450-4496-1-git-send-email-niklass@axis.com> Date: Mon, 27 Apr 2015 14:59:39 -0300 Message-ID: Subject: Re: [PATCH] net: phy: micrel: support !CONFIG_HAVE_CLK From: Fabio Estevam To: Niklas Cassel Cc: "David S. Miller" , Florian Fainelli , "netdev@vger.kernel.org" , linux-kernel , johan@kernel.org, Niklas Cassel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 21 On Mon, Apr 27, 2015 at 8:00 AM, Niklas Cassel wrote: > Since NULL is a valid clock, we shouldn't use > IS_ERR_OR_NULL. Yes, but this code is not using IS_ERR_OR_NULL. It seems that you are not describing the problem you are trying to solve. What is the exact issue you are seeing? > clk = devm_clk_get(&phydev->dev, "rmii-ref"); You need to provide the 'rmii-ref' in your board file or dts. Are you doing this? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/