Date: Mon, 27 Apr 2015 14:00:18 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Dave P Martin <Dave.Martin@arm.com>
Cc: Alex =?UTF-8?B?QmVubsOpZQ==?= <alex.bennee@linaro.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Oleg Nesterov <oleg@redhat.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Petr Mladek <pmladek@suse.cz>
Subject: Re: [PATCH] tracing: make ftrace_print_array_seq compute buf_len
Message-ID: <20150427140018.5b64cac3@gandalf.local.home>
In-Reply-To: <20150427142201.GB3590@e103592.cambridge.arm.com>
References: <1430137069-859-1-git-send-email-alex.bennee@linaro.org>
	<20150427142201.GB3590@e103592.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1627
Lines: 53

On Mon, 27 Apr 2015 15:22:02 +0100
Dave P Martin <Dave.Martin@arm.com> wrote:

> On Mon, Apr 27, 2015 at 01:17:48PM +0100, Alex Bennée wrote:
> > The only caller to this function was getting it wrong. I favoured
> 
> What caller?
> 
> Wrong in what way?

Yes, please add that info to the change log.

> 
> > pushing the calculation to as close to the need as possible rather than
> > fixing the one caller.
> 
> This seems reasonable, but...
> 
> > 
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> > ---
> >  include/linux/ftrace_event.h | 2 +-
> >  kernel/trace/trace_output.c  | 3 ++-
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h
> > index c674ee8..e6b0262 100644
> > --- a/include/linux/ftrace_event.h
> > +++ b/include/linux/ftrace_event.h
> > @@ -45,7 +45,7 @@ const char *ftrace_print_hex_seq(struct trace_seq *p,
> >  				 const unsigned char *buf, int len);
> >  
> >  const char *ftrace_print_array_seq(struct trace_seq *p,
> > -				   const void *buf, int buf_len,
> > +				   const void *buf, int len,
> 
> How is the name "len" less confusing than "buf_len"?
> 
> I suggest matching the name to the equivalent argument of the
> __print_array macro -- i.e., "count".

I agree, please change the variable name to "count", that will make more
sense.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/