Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965082AbbD0Spn (ORCPT ); Mon, 27 Apr 2015 14:45:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964801AbbD0Spj (ORCPT ); Mon, 27 Apr 2015 14:45:39 -0400 Date: Mon, 27 Apr 2015 15:45:35 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: David Ahern , Will Deacon , "linux-kernel@vger.kernel.org" , Mark Rutland , Jiri Olsa , Namhyung Kim Subject: Re: arm/arm64 perf build issue with mainline Message-ID: <20150427184535.GD2698@redhat.com> References: <5538FEAF.5040804@oracle.com> <20150424161058.GA19673@redhat.com> <20150424162238.GD7313@arm.com> <553A7BB2.8040706@oracle.com> <20150427162622.GC16849@kernel.org> <553E6E1E.9060805@oracle.com> <20150427174017.GB2698@redhat.com> <20150427174906.GA474@krava.redhat.com> <20150427183953.GC2698@redhat.com> <20150427184120.GB474@krava.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150427184120.GB474@krava.redhat.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2943 Lines: 76 Em Mon, Apr 27, 2015 at 08:41:20PM +0200, Jiri Olsa escreveu: > On Mon, Apr 27, 2015 at 03:39:53PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Apr 27, 2015 at 07:49:06PM +0200, Jiri Olsa escreveu: > > > On Mon, Apr 27, 2015 at 02:40:17PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em Mon, Apr 27, 2015 at 11:13:02AM -0600, David Ahern escreveu: > > > > > > > > > > I think the right thing to do is to remove JOBS completely. > > > > > > > > That is up for discussion, Ingo, Jiri, Namhyung, others? > > > > > > > > > Barring that use of getconf with a fallback to grepping /proc/cpuinfo. > > > > > > > > Ok, but no patch so far doing that, right? 8-) > > > > > > heh, I've got the idea that you're preparing something ;-) > > > > > > as for me I've got used to the automatic -jX being added, > > > so I'd prefer we fix that JOBS setup for arm > > > > > > I'll try to send something ;-) > > > > [acme@ssdandy linux]$ (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU' /proc/cpuinfo) 2>/dev/null > > 8 > > [acme@ssdandy linux]$ (not-found-getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU' /proc/cpuinfo) 2>/dev/null > > 8 > > [acme@ssdandy linux]$ > > > > how about this one I came up with this one, that doesn't introduces a new file: >From e8155c06652a05f2307d53823a7937be5dad4e32 Mon Sep 17 00:00:00 2001 From: Will Deacon Date: Thu, 23 Apr 2015 15:00:16 +0100 Subject: [PATCH] tools perf: Use getconf to determine number of online CPUs Parsing /proc/cpuinfo is a fiddly, arch-dependent business anda recent change to get it working for Sparc broke arm and arm64 platforms. Use sysconf to determine the number of online CPUs only parsing /proc/cpuinfo when sysconf is not available. Signed-off-by: Will Deacon Cc: David Ahern Cc: Jiri Olsa Cc: Mark Rutland Cc: Namhyung Kim Link: http://lkml.kernel.org/r/20150423140454.GJ1652@arm.com [ Made it fall back to parsing /proc when getconf not found ] Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/Makefile b/tools/perf/Makefile index c699dc35eef9..bc846b83c295 100644 --- a/tools/perf/Makefile +++ b/tools/perf/Makefile @@ -24,7 +24,7 @@ unexport MAKEFLAGS # (To override it, run 'make JOBS=1' and similar.) # ifeq ($(JOBS),) - JOBS := $(shell egrep -c '^processor|^CPU' /proc/cpuinfo 2>/dev/null) + JOBS := $(shell (getconf _NPROCESSORS_ONLN || egrep -c '^processor|^CPU' /proc/cpuinfo) 2>/dev/null) ifeq ($(JOBS),0) JOBS := 1 endif -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/