Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965674AbbD0Vwp (ORCPT ); Mon, 27 Apr 2015 17:52:45 -0400 Received: from mga14.intel.com ([192.55.52.115]:13664 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965158AbbD0Vwl (ORCPT ); Mon, 27 Apr 2015 17:52:41 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,660,1422950400"; d="scan'208";a="686512915" Date: Mon, 27 Apr 2015 17:52:30 -0400 From: "ira.weiny" To: Michael Wang Cc: Liran Liss , Roland Dreier , Sean Hefty , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Steve Wise , Tom Talpey , Jason Gunthorpe , Doug Ledford , Tom Tucker , Hoang-Nam Nguyen , "raisch@de.ibm.com" , Mike Marciniszyn , Eli Cohen , Faisal Latif , Jack Morgenstein , Or Gerlitz , Haggai Eran Subject: Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() Message-ID: <20150427215229.GD5347@phlsvsds.ph.intel.com> References: <1429878230-11749-1-git-send-email-yun.wang@profitbricks.com> <1429878230-11749-2-git-send-email-yun.wang@profitbricks.com> <553DE799.5050608@profitbricks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <553DE799.5050608@profitbricks.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1931 Lines: 59 On Mon, Apr 27, 2015 at 09:39:05AM +0200, Michael Wang wrote: > > > On 04/24/2015 05:12 PM, Liran Liss wrote: > >> From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > >> > > [snip] > >> a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > >> 65994a1..d54f91e 100644 > >> --- a/include/rdma/ib_verbs.h > >> +++ b/include/rdma/ib_verbs.h > >> @@ -75,10 +75,13 @@ enum rdma_node_type { }; > >> > >> enum rdma_transport_type { > >> + /* legacy for users */ > >> RDMA_TRANSPORT_IB, > >> RDMA_TRANSPORT_IWARP, > >> RDMA_TRANSPORT_USNIC, > >> - RDMA_TRANSPORT_USNIC_UDP > >> + RDMA_TRANSPORT_USNIC_UDP, > >> + /* new transport */ > >> + RDMA_TRANSPORT_IBOE, > > > > Remove RDMA_TRANSPORT_IBOE - it is not a transport. > > ROCE uses IBTA transport. > > > > If any code should test for ROCE should invoke a specific helper, e.g., rdma_protocol_iboe(). > > This is what you currently call "rdma_tech_iboe" is patch 02/26. > > > > I think that pretty much everybody agrees that rdma_protocol_*() is a better name than rdma_tech_*(), right? > > So, let's change this. > > Sure, sounds reasonable now, about the IBOE, we still need it to > separate the port support IB/ETH without the check on link-layer, > So what about a new enum on protocol type? > > Like: > > enum rdma_protocol { > RDMA_PROTOCOL_IB, > RDMA_PROTOCOL_IBOE, > RDMA_PROTOCOL_IWARP, > RDMA_PROTOCOL_USNIC_UDP > }; > > So we could use query_protocol() to ask device provide the protocol > type, and there will be no mixing with the legacy transport type > anymore :-) I'm ok with that. I like introducing a unique namespace which is clearly different from the previous "transport" one. Ira -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/