Message-ID: <553EB536.8020404@zytor.com>
Date: Mon, 27 Apr 2015 15:16:22 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Denys Vlasenko <dvlasenk@redhat.com>, Ingo Molnar <mingo@kernel.org>
CC: Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs
References: <1430140912-7960-1-git-send-email-dvlasenk@redhat.com>
In-Reply-To: <1430140912-7960-1-git-send-email-dvlasenk@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 795
Lines: 27

On 04/27/2015 06:21 AM, Denys Vlasenko wrote:
> 
> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
> index e952f6b..8f8b22a 100644
> --- a/arch/x86/kernel/entry_64.S
> +++ b/arch/x86/kernel/entry_64.S
> @@ -666,7 +666,7 @@ END(irq_entries_start)
>  	leaq -RBP(%rsp),%rdi	/* arg1 for \func (pointer to pt_regs) */
>  
>  	testl $3, CS-RBP(%rsp)
> -	je 1f
> +	jz	1f
>  	SWAPGS
>  1:

Please don't insert tabs between opcode and operand unless that is the
style of the surrounding code.

Otherwise this patchset looks good.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/