Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965717AbbD0Wnu (ORCPT ); Mon, 27 Apr 2015 18:43:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40082 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965487AbbD0Wnp (ORCPT ); Mon, 27 Apr 2015 18:43:45 -0400 Date: Mon, 27 Apr 2015 15:43:44 -0700 From: Andrew Morton To: Mel Gorman Cc: Linux-MM , Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , LKML Subject: Re: [PATCH 07/13] mm: meminit: Initialise a subset of struct pages if CONFIG_DEFERRED_STRUCT_PAGE_INIT is set Message-Id: <20150427154344.421fd9f151bf27d365d02fd2@linux-foundation.org> In-Reply-To: <1429785196-7668-8-git-send-email-mgorman@suse.de> References: <1429785196-7668-1-git-send-email-mgorman@suse.de> <1429785196-7668-8-git-send-email-mgorman@suse.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 28 On Thu, 23 Apr 2015 11:33:10 +0100 Mel Gorman wrote: > This patch initalises all low memory struct pages and 2G of the highest zone > on each node during memory initialisation if CONFIG_DEFERRED_STRUCT_PAGE_INIT > is set. That config option cannot be set but will be available in a later > patch. Parallel initialisation of struct page depends on some features > from memory hotplug and it is necessary to alter alter section annotations. > > ... > > +#ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT > +#define __defermem_init __meminit > +#define __defer_init __meminit > +#else > +#define __defermem_init > +#define __defer_init __init > +#endif Could we get some comments describing these? What they do, when and where they should be used. I have a suspicion that the naming isn't good, but I didn't spend a lot of time reverse-engineering the intent... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/