Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965775AbbD0WoA (ORCPT ); Mon, 27 Apr 2015 18:44:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40096 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965722AbbD0Wn5 (ORCPT ); Mon, 27 Apr 2015 18:43:57 -0400 Date: Mon, 27 Apr 2015 15:43:56 -0700 From: Andrew Morton To: Mel Gorman Cc: Linux-MM , Nathan Zimmer , Dave Hansen , Waiman Long , Scott Norton , Daniel J Blueman , LKML Subject: Re: [PATCH 11/13] mm: meminit: Free pages in large chunks where possible Message-Id: <20150427154356.67e3d186b732a2c2b00e49cb@linux-foundation.org> In-Reply-To: <1429785196-7668-12-git-send-email-mgorman@suse.de> References: <1429785196-7668-1-git-send-email-mgorman@suse.de> <1429785196-7668-12-git-send-email-mgorman@suse.de> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 17 On Thu, 23 Apr 2015 11:33:14 +0100 Mel Gorman wrote: > Parallel struct page frees pages one at a time. Try free pages as single > large pages where possible. > > ... > > void __defermem_init deferred_init_memmap(int nid) This function is gruesome in an 80-col display. Even the code comments wrap, which is nuts. Maybe hoist the contents of the outermost loop into a separate function, called for each zone? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/