Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752754AbbD1AIJ (ORCPT ); Mon, 27 Apr 2015 20:08:09 -0400 Received: from blu004-omc1s23.hotmail.com ([65.55.116.34]:64410 "EHLO BLU004-OMC1S23.hotmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbbD1AIF (ORCPT ); Mon, 27 Apr 2015 20:08:05 -0400 X-TMN: [j90mMjcIIQ4f+fxZbfCDZTBHXGX2laKT] X-Originating-Email: [minfei.huang@hotmail.com] Message-ID: Date: Tue, 28 Apr 2015 08:08:00 +0800 From: Minfei Huang To: Jiri Kosina CC: x86@kernel.org, Borislav Petkov , Kees Cook , Josh Poimboeuf , Seth Jennings , Vojtech Pavlik , linux-kernel@vger.kernel.org, live-patching@vger.kernel.org Subject: Re: [PATCH 2/2] livepatch: x86: make kASLR logic more accurate References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-OriginalArrivalTime: 28 Apr 2015 00:08:03.0998 (UTC) FILETIME=[658A7BE0:01D08147] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1353 Lines: 38 On 04/28/15 at 01:29P, Jiri Kosina wrote: > On Mon, 27 Apr 2015, Minfei Huang wrote: > > > Found that kaslr_enabled is only exist for x86. Maybe you can define a > > weak function klp_adjustment_function_addr in general. Then each arch > > can overwrite the function to implemente it specially. > > It might start to make sense once there is at least one additional arch > that supports kaslr. Currently, I don't see a benefit. > > Why are you so obstinate about this? I personally don't find that > important at all; it's something that can always be sorted out once more > archs start supporting kaslr. > ohhh... Previously, IMO, putting the relevant function address adjustment into the specified arch is more clearly to be reviewed and understood. Now, I know what you actual want according to above commit, I am fine with it. Thanks Minfei > Thanks, > > -- > Jiri Kosina > SUSE Labs > -- > To unsubscribe from this list: send the line "unsubscribe live-patching" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/