Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932792AbbD1CV4 (ORCPT ); Mon, 27 Apr 2015 22:21:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59190 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932233AbbD1CVz (ORCPT ); Mon, 27 Apr 2015 22:21:55 -0400 From: Joonwoo Park To: tglx@linutronix.de Cc: sboyd@codeaurora.org, skannan@codeaurora.org, linux-kernel@vger.kernel.org, Joonwoo Park , John Stultz Subject: [PATCH 1/2] timer: avoid unnecessary waking up of nohz CPU Date: Mon, 27 Apr 2015 19:21:49 -0700 Message-Id: <1430187709-21087-1-git-send-email-joonwoop@codeaurora.org> X-Mailer: git-send-email 1.8.2.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 33 At present, internal_add_timer() examines flags with 'base' which doesn't contain flags. Examine with 'timer->base' to avoid unnecessary waking up of nohz CPU when timer base has TIMER_DEFERRABLE. CC: Thomas Gleixner CC: John Stultz Signed-off-by: Joonwoo Park --- kernel/time/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/timer.c b/kernel/time/timer.c index 2ece3aa..e5d5733c 100644 --- a/kernel/time/timer.c +++ b/kernel/time/timer.c @@ -434,7 +434,7 @@ static void internal_add_timer(struct tvec_base *base, struct timer_list *timer) * require special care against races with idle_cpu(), lets deal * with that later. */ - if (!tbase_get_deferrable(base) || tick_nohz_full_cpu(base->cpu)) + if (!tbase_get_deferrable(timer->base) || tick_nohz_full_cpu(base->cpu)) wake_up_nohz_cpu(base->cpu); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/