Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933155AbbD1Hkm (ORCPT ); Tue, 28 Apr 2015 03:40:42 -0400 Received: from mail-qc0-f180.google.com ([209.85.216.180]:33676 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932140AbbD1Hkk (ORCPT ); Tue, 28 Apr 2015 03:40:40 -0400 MIME-Version: 1.0 In-Reply-To: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> References: <1430159072-31440-1-git-send-email-grygorii.strashko@linaro.org> Date: Tue, 28 Apr 2015 09:40:39 +0200 Message-ID: Subject: Re: [PATCH 0/3] Introduce SET_NOIRQ_SYSTEM_SLEEP_PM_OPS and use it From: Ulf Hansson To: Grygorii Strashko Cc: "Rafael J. Wysocki" , Pavel Machek , Len Brown , "linux-pm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-omap , "linux-kernel@vger.kernel.org" , Tony Lindgren , Nishanth Menon , Kevin Hilman , Santosh Shilimkar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2185 Lines: 55 On 27 April 2015 at 20:24, wrote: > From: Grygorii Strashko > > While working on suspend-to-disk functionality on TI dra7-evm (DRA7xx SoC) > i've found that the most common problem I have to dial with is absence > of corresponding PM callbacks in drivers and, in particular, noirq callbacks. > So, I've fixed one driver first > commit 6248015d6867 "ARM: omap-device: add missed callback for suspend-to-disk" > but then found another one which need to be fixed too (omap_l3_noc.c). > At this moment I decided to make my life easier and added new macro > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS using the same approach as for the existing > SET_SYSTEM_SLEEP_PM_OPS macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS: defined for CONFIG_PM_SLEEP and > assigns ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Further two patches reuse this newly introduced macro. > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS, defined for CONFIG_PM_SLEEP, will > point ->suspend_noirq, ->freeze_noirq and ->poweroff_noirq to the same > function. Vice versa happens for ->resume_noirq, ->thaw_noirq and > ->restore_noirq. > > Cc: Tony Lindgren > Cc: Nishanth Menon > Cc: Kevin Hilman > Cc: Santosh Shilimkar > > Grygorii Strashko (3): > PM / Sleep: Add macro to define common noirq system PM callbacks > bus: omap_l3_noc: add missed callbacks for suspend-to-disk > ARM: omap-device: use SET_NOIRQ_SYSTEM_SLEEP_PM_OPS > > arch/arm/mach-omap2/omap_device.c | 7 ++----- > drivers/bus/omap_l3_noc.c | 4 ++-- > include/linux/pm.h | 12 ++++++++++++ > 3 files changed, 16 insertions(+), 7 deletions(-) > > -- > 1.9.1 > For the patchset. Reviewed-by: Ulf Hansson Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/